Pass successUrl and cancelUrl to createStripeCheckoutSession cloud function
#1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
feature: sharezone plus
|
Visit the preview URL for this PR (updated for commit 0c063c0): https://sharezone-test--pr1171-add-cancel-and-succe-i5kdrebq.web.app (expires Sun, 10 Dec 2023 22:38:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
Jonas-Sander
reviewed
Dec 7, 2023
Comment on lines
83
to
84
| // payment is completed or canceled. We only use the base URL because we a | ||
| // whitelist for the allowed URLs. |
There was a problem hiding this comment.
Last sentence is incomplete. Also I don't follow the argument, I mean the backend could also just match the base url if a longer url is send, no? I guess the argument is so that we have to do less parsing in the backend we only send the base url, correct?
There was a problem hiding this comment.
Changed the backend that it only needs to match the beginning of the URL ✅
Jonas-Sander
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo
Screen.Recording.2023-12-07.at.19.03.17.mov