Skip to content

Commit

Permalink
Disable concurrency for sz command in our CI/CD pipeline (#1659)
Browse files Browse the repository at this point in the history
Not sure if there is another easy way to fix #1658

---------

Co-authored-by: Jonas Sander <[email protected]>
  • Loading branch information
nilsreichardt and Jonas-Sander authored Jun 12, 2024
1 parent 21a07a1 commit a9ca9e5
Show file tree
Hide file tree
Showing 4 changed files with 34 additions and 16 deletions.
17 changes: 11 additions & 6 deletions .github/workflows/cli_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,11 @@ jobs:
- run: echo $(realpath ./bin) >> $GITHUB_PATH

- name: Run code analysis via "sz analyze" (formatting, issues, spacing ...)
# We don't run the analysis in parallel to prevent
# https://github.com/SharezoneApp/sharezone-app/issues/1658.
run: |
sz analyze \
--max-concurrent-packages 3 \
--max-concurrent-packages 1 \
--package-timeout-minutes 15 \
--only sz_repo_cli
Expand Down Expand Up @@ -139,8 +141,11 @@ jobs:
# Because of this, we need to exclude the golden tests because they
# require a macOS runner.
- name: Run tests via "sz test"
run: sz test \
-c 4 \
--package-timeout-minutes 15 \
--exclude-goldens \
--only sz_repo_cli
# We don't run the analysis in parallel to prevent
# https://github.com/SharezoneApp/sharezone-app/issues/1658.
run: |
sz test \
-c 1 \
--package-timeout-minutes 15 \
--exclude-goldens \
--only sz_repo_cli
17 changes: 11 additions & 6 deletions .github/workflows/safe_app_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,12 @@ jobs:
- run: echo $(realpath ./bin) >> $GITHUB_PATH

- name: Run code analysis via "sz analyze" (formatting, issues, spacing ...)
run: sz analyze --max-concurrent-packages 3 --package-timeout-minutes 15
# We don't run the analysis in parallel to prevent
# https://github.com/SharezoneApp/sharezone-app/issues/1658.
run: |
sz analyze \
--max-concurrent-packages 1 \
--package-timeout-minutes 15
# We split the tests into two jobs, because we want to run the golden tests on
# a macOS runner, because the golden tests were generated on macOS. To reduce
Expand Down Expand Up @@ -145,9 +150,11 @@ jobs:
- run: echo $(pwd)/bin >> $GITHUB_PATH

- name: Run tests via "sz test"
# We don't run the analysis in parallel to prevent
# https://github.com/SharezoneApp/sharezone-app/issues/1658.
run: |
sz test \
-c 4 \
-c 1 \
--package-timeout-minutes 15 \
--exclude-goldens
Expand Down Expand Up @@ -178,11 +185,9 @@ jobs:
flutter pub global activate --source path "$CI_CD_DART_SCRIPTS_PACKAGE_PATH"
echo $(pwd)/bin >> $GITHUB_PATH
# Running with -c 1 as using -c 4 would lead to to this dependency error:
# https://github.com/SharezoneApp/sharezone-app/pull/1322#issuecomment-1981410505
# We don't know why this happens.
# In the future please try to use a higher concurrency value again.
- name: Run tests via "sz test"
# We don't run the analysis in parallel to prevent
# https://github.com/SharezoneApp/sharezone-app/issues/1658.
run: |
sz test \
-c 1 \
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/safe_console_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,9 @@ jobs:
echo $(pwd)/bin >> $GITHUB_PATH
- name: Run code analysis via "sz analyze" (formatting, issues, spacing ...)
run: sz analyze \
--max-concurrent-packages 3 \
--package-timeout-minutes 15
# We don't run the analysis in parallel to prevent
# https://github.com/SharezoneApp/sharezone-app/issues/1658.
run: |
sz analyze \
--max-concurrent-packages 1 \
--package-timeout-minutes 15
7 changes: 6 additions & 1 deletion .github/workflows/safe_website_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -115,4 +115,9 @@ jobs:
- run: echo $(realpath ./bin) >> $GITHUB_PATH

- name: Run code analysis via "sz analyze" (formatting, issues, spacing ...)
run: sz analyze --max-concurrent-packages 3 --package-timeout-minutes 15
# We don't run the analysis in parallel to prevent
# https://github.com/SharezoneApp/sharezone-app/issues/1658.
run: |
sz analyze \
--max-concurrent-packages 1 \
--package-timeout-minutes 15

0 comments on commit a9ca9e5

Please sign in to comment.