Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small Ghost Note Removal Fixes #16011

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Small Ghost Note Removal Fixes #16011

wants to merge 6 commits into from
+14 −2

Conversation

DMMaster636
Copy link
Contributor

@DMMaster636 DMMaster636 commented Dec 5, 2024 •
edited
Loading

Fixes:

  • Ghost Sustains not being removed (me)
  • Not accounting for floating-point inaccuracies (crowplexus)

crowplexus
crowplexus approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@crowplexus crowplexus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mb chat

@crowplexus
Copy link
Contributor

sent a PR for strumTime checking btw!

@DMMaster636
Merge pull request #7 from crowplexus/patch-5
e8d7b30 
Account for floating-point inaccuracies
@DMMaster636 DMMaster636 changed the title Fix Ghost Note Sustains not being removed Small Ghost Note Removal Fixes Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowplexus crowplexus crowplexus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DMMaster636 @crowplexus