Discount overview on Arx purchase page and price calculation change #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculated discount % and example arx:price values are added on each Arx package on the Arx purchase page.
The window load event is only fired when the entire page has been loaded, including all resourses like scripts, stylesheets and images. This is unreliable especially with ad- and privacy blockers preventing certain files to load. Replaced it with a DOMready() function that triggers earlier and always. The decimals handling of prices has been simplified using toFixed(2). Note on Number.EPSILON; It doesn't prevent floating-point errors in the way it's used here. In rare occasions it could prevent incorrectly rounding down instead of up but the 0.01 difference doesn't matter here and we're also not doing direct equality comparisons.
Prices for each item are now calculated using the lowest Arx package possible to buy that specific item. It does not make sense if an item costs 12500 to use the 8400 package and calculate leftovers with the 5000 package. This would be more expensive than simply buying the larger 16800 package. Also a few fixes I missed and all my tabs were messed up...
- Changes the way prices are calculated - Adds discount-% overview on Arx purchase page - Readme changed to reflect changes made with new screenshots
Updated the readme to reflect the changes of how the script works and calculates prices. - New shop screenshots added - Details for all settings added
Initially this was intended to just be an update for the original version but it seems the original author is not doing anything with the push request. Metadata header was changed to make this a separate standalone version so userscript managers won't look at the original URL for updates.
|
Oh shoot I completely forgot about this. Sorry about that. Maybe it is better in it's own userscript, you seem to care for it more than I do :) |
|
No problem, I just changed the metadata URL in my version because if I linked my version to people the script would still point to your version and perhaps look here for updates. I didn't realize doing that would also update this pull request which was not intended, so I figured I'd just close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple changes as mentioned in (#1):