Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DualSense): add DualSense target gamepad #38

Merged
merged 9 commits into from
Apr 14, 2024
Merged

Conversation

ShadowApex
Copy link
Contributor

No description provided.

@ShadowApex ShadowApex force-pushed the shadowapex/dualsense branch 17 times, most recently from 1366875 to 8ec83f9 Compare April 11, 2024 00:12
@pastaq
Copy link
Contributor

pastaq commented Apr 11, 2024

Tested on ROG Ally. Motion in game seems to be correct, but the gyro calibration screen reports show roll and yaw swapped.

Also, the guide button only works like 1/6 of the time now. QAM always works.

@ShadowApex ShadowApex marked this pull request as ready for review April 11, 2024 19:20
@ShadowApex ShadowApex force-pushed the shadowapex/dualsense branch from 0a5dfaf to 71a3f84 Compare April 11, 2024 21:16
@ShadowApex ShadowApex force-pushed the shadowapex/dualsense branch from 71a3f84 to 9697e45 Compare April 11, 2024 21:18
@ShadowApex ShadowApex requested a review from pastaq April 11, 2024 21:25
@ShadowApex ShadowApex force-pushed the shadowapex/dualsense branch from 2d1b5b0 to d36eafd Compare April 12, 2024 06:30
@ShadowApex ShadowApex force-pushed the shadowapex/dualsense branch 4 times, most recently from 1242242 to fac7db6 Compare April 14, 2024 01:30
@ShadowApex ShadowApex force-pushed the shadowapex/dualsense branch from fac7db6 to 7f59c41 Compare April 14, 2024 01:51
@@ -307,10 +314,11 @@ pub struct CompositeDevice {
/// E.g. {"/org/shadowblip/InputPlumber/devices/target/dbus0": <Sender>}
target_dbus_devices: HashMap<String, mpsc::Sender<TargetCommand>>,
/// Set of available Force Feedback effect IDs that are not in use
/// TODO: Just use the keys from ff_effect_id_source_map to determine next id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;)

@@ -155,87 +161,155 @@ impl EventDevice {

// Loop to read events from the device and commands over the channel
log::debug!("Reading events from {}", path);
'main: loop {
let mut interval = tokio::time::interval(POLL_RATE);
loop {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change

Copy link
Contributor

@pastaq pastaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShadowApex ShadowApex merged commit c38a94a into main Apr 14, 2024
2 checks passed
@ShadowApex ShadowApex deleted the shadowapex/dualsense branch April 14, 2024 03:05
Copy link

🎉 This PR is included in version 0.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants