[dotnet] Add nullability to Manage()
#15210
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Add nullability to
Manage()
Motivation and Context
Contributes to #14640
Types of changes
Checklist
PR Type
Enhancement, Bug fix
Description
Enabled nullable reference types across multiple files for improved null safety.
Refactored properties to use expression-bodied members for conciseness.
Added null checks and updated constructors to throw
ArgumentNullException
where necessary.Improved type safety by updating dictionary value types and handling potential null values.
Changes walkthrough 📝
IOptions.cs
Enable nullable reference types in `IOptions`
dotnet/src/webdriver/IOptions.cs
#nullable enable
directive for null safety.ITimeouts.cs
Enable nullable reference types in `ITimeouts`
dotnet/src/webdriver/ITimeouts.cs
#nullable enable
directive for null safety.IWindow.cs
Enable nullable reference types in `IWindow`
dotnet/src/webdriver/IWindow.cs
#nullable enable
directive for null safety.OptionsManager.cs
Refactor `OptionsManager` and enable nullable reference types
dotnet/src/webdriver/OptionsManager.cs
OptionsManager
to a sealed class.Timeouts.cs
Refactor `Timeouts` and enable nullable reference types
dotnet/src/webdriver/Timeouts.cs
Window.cs
Refactor `Window` and enable nullable reference types
dotnet/src/webdriver/Window.cs
Window
to a sealed class.