Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use more function calls in functions.j2 #308

Closed
wants to merge 13 commits into from

Conversation

JonZeolla
Copy link
Member

@JonZeolla JonZeolla commented Nov 7, 2023

Contributor Comments

This is a precursor refactor step so we can add post-hooks. Currently we have pre-hooks, but post-hooks requires a somewhat major refactor, so breaking this into two steps to simplify review.

Pull Request Checklist

Thank you for submitting a contribution to our project!

In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

  • Rebase your branch against the latest commit of the target branch.
  • If you are adding a dependency, please explain how it was chosen.
  • If manual testing is needed in order to validate the changes, provide a testing plan and the expected results.
  • If there is an issue associated with your Pull Request, link the issue to the PR.
  • Validate that documentation is accurate and aligned to any project updates or additions.

Don't forget our more detailed contribution guidelines
here.

version_argument: --version
git:
helper:
- all
version: v2.42.0
version_argument: --version
kics:
version: v1.7.8
version: v1.7.10
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to keep this at 10 and not 11 until the upstream irons out the multiplatform builds per Checkmarx/kics#6800

@JonZeolla
Copy link
Member Author

This refactor is going sideways, we need to get rid of all the bash and use a more capable language.

@JonZeolla
Copy link
Member Author

We're going to replace bash with go so this can be done sanely

@JonZeolla JonZeolla closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants