-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use more function calls in functions.j2 #308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seiso Automation <[email protected]> Co-authored-by: JonZeolla <[email protected]>
JonZeolla
commented
Nov 14, 2023
version_argument: --version | ||
git: | ||
helper: | ||
- all | ||
version: v2.42.0 | ||
version_argument: --version | ||
kics: | ||
version: v1.7.8 | ||
version: v1.7.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to keep this at 10 and not 11 until the upstream irons out the multiplatform builds per Checkmarx/kics#6800
This refactor is going sideways, we need to get rid of all the bash and use a more capable language. |
We're going to replace bash with go so this can be done sanely |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Comments
This is a precursor refactor step so we can add post-hooks. Currently we have pre-hooks, but post-hooks requires a somewhat major refactor, so breaking this into two steps to simplify review.
Pull Request Checklist
Thank you for submitting a contribution to our project!
In order to streamline the review of your contribution we ask that you review and comply with the below requirements:
Don't forget our more detailed contribution guidelines
here.