Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with_cte to include WITH clauses in Statements #859

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rumpuslabs
Copy link

…instead of separate WithQuery

PR Info

New Features

  • Adds with_cte method to SelectStatement/UpdateStatement/InsertStatement/DeleteStatement to allow adding WITH clauses to any query

Notes

  • I had to choose another method name to avoid breaking backward compatibiity of the existing fn with(...) -> WithQuery. I'm not completely happy with with_cte but couldn't think of anything better.
  • If the intention is to eventually remove WithQuery, we could add #[deprecated] to thewith methods to encourage users to migrate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify SelectStatement and WithQuery
1 participant