Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unnecessary string hashes #815

Merged

Conversation

hamirmahal
Copy link
Contributor

Breaking Changes

This change is backward compatible.

Changes

  • This removes unnecessary string hashes to improve readability.

Copy link
Contributor Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billy1624 are you open to this pull request?

tests/sqlite/query.rs Outdated Show resolved Hide resolved
@hamirmahal hamirmahal force-pushed the refactor/remove-unnecessary-string-hashes branch from 9d464d8 to dd86f38 Compare October 7, 2024 17:25
@hamirmahal hamirmahal force-pushed the refactor/remove-unnecessary-string-hashes branch from dd86f38 to 65deaee Compare October 7, 2024 17:30
@hamirmahal hamirmahal requested a review from tyt2y3 October 7, 2024 17:41
tests/sqlite/table.rs Outdated Show resolved Hide resolved
@hamirmahal hamirmahal requested a review from tyt2y3 October 8, 2024 21:30
@hamirmahal
Copy link
Contributor Author

@tyt2y3 are you open to this change?

Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@tyt2y3 tyt2y3 merged commit ea1d9fa into SeaQL:master Nov 28, 2024
20 checks passed
@hamirmahal hamirmahal deleted the refactor/remove-unnecessary-string-hashes branch November 28, 2024 20:01
@hamirmahal
Copy link
Contributor Author

You're welcome.

Copy link

github-actions bot commented Dec 1, 2024

🎉 Released In 0.32.1 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants