Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] 과제 삭제 연관관계 해결, 커스텀 예외처리 사용 #138

Merged
merged 7 commits into from
Nov 26, 2024
Merged

[REFACTOR] 과제 삭제 연관관계 해결, 커스텀 예외처리 사용 #138

merged 7 commits into from
Nov 26, 2024

Conversation

sseung519
Copy link
Contributor

@sseung519 sseung519 commented Nov 26, 2024 •
edited
Loading

관련 이슈

변경 사항

Assignment 엔티티 Submission 필드 생성 -> OneToMany 연관관계와 cascade = CascadeType.REMOVE 설정
Assignment 패키지 내 CustomException 구현
AssignmentService, SubmissionService 내 CustomException 리팩토링

스크린샷

기능 스크린샷
CRS-003 image

체크리스트

  • 코드 컨벤션을 준수하였습니까?
  • 모든 테스트를 통과하였습니까?
  • 관련 문서를 업데이트하였습니까?

추후 업무

  • 유저 기준 컨트롤러 분리(기존: Assignment, Submisson 도메인별 컨트롤러)

@sseung519 sseung519 added the refactoring Enhancing code structure for better readability and maintainability label Nov 26, 2024
@sseung519 sseung519 self-assigned this Nov 26, 2024
Chan-GN
Chan-GN approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@Chan-GN Chan-GN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

커스텀 예외 처리를 가이드에 맞게 잘 수정해주셨네요!
권한 검증도 꼼꼼하게 잘 해주셨네요 ㅎ 배워갑니다...

고생 많으셨습니다!

@sseung519
REFACTOR: BaseUser삭제
e63bd3b 
- @CurrentUserEmail로 email을 가져오는 경우 InstructorRepository의 findByEmail로 바로 검증
@sseung519
FEAT: findByEmail 쿼리 구현
29931e0
@sseung519 sseung519 requested review from cuteJJong and removed request for liimjiin November 26, 2024 05:31
cuteJJong
cuteJJong approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@cuteJJong cuteJJong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예외 처리, 권한 검증 너무 잘해 주신 것 같습니다. 많이 배웠습니다

@sseung519 sseung519 merged commit 9b2fac0 into main Nov 26, 2024
@sseung519 sseung519 deleted the refactor/132-use-global-exception branch November 26, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuteJJong cuteJJong cuteJJong approved these changes

@Chan-GN Chan-GN Chan-GN approved these changes

Assignees

@sseung519 sseung519

Labels
refactoring Enhancing code structure for better readability and maintainability
Projects
Epari-backend
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] 과제 삭제 연관관계 해결, 커스텀 예외처리 사용
3 participants
@sseung519 @cuteJJong @Chan-GN