Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: tests and docs #264

Merged
merged 6 commits into from
Jan 24, 2025
Merged

settings: tests and docs #264

merged 6 commits into from
Jan 24, 2025

Conversation

lennartkloock
Copy link
Member

@lennartkloock lennartkloock commented Jan 23, 2025

  • Simplify parsing function
  • Add tests
  • Add docs

Copy link

cloudflare-workers-and-pages bot commented Jan 23, 2025

Deploying scuffle-docrs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 123f15e
Status: ✅  Deploy successful!
Preview URL: https://e31523d6.scuffle-docrs.pages.dev
Branch Preview URL: https://pr-264.scuffle-docrs.pages.dev

View logs

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.92%. Comparing base (c06e35d) to head (123f15e).
Report is 13 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
+ Coverage   63.07%   63.92%   +0.85%     
==========================================
  Files         202      203       +1     
  Lines       15849    15846       -3     
==========================================
+ Hits         9996    10129     +133     
+ Misses       5853     5717     -136     
Files with missing lines Coverage Δ
crates/settings/src/lib.rs 93.28% <100.00%> (+93.28%) ⬆️
crates/settings/src/options.rs 100.00% <100.00%> (ø)
Components Coverage Δ
scuffle-aac 89.65% <ø> (ø)
scuffle-amf0 100.00% <ø> (ø)
scuffle-av1 98.66% <ø> (ø)
scuffle-batching 100.00% <ø> (ø)
scuffle-bootstrap 86.50% <ø> (ø)
scuffle-bytes-util 100.00% <ø> (ø)
scuffle-context 100.00% <ø> (ø)
scuffle-expgolomb 100.00% <ø> (ø)
scuffle-ffmpeg 31.81% <ø> (ø)
scuffle-flv 94.76% <ø> (ø)
scuffle-future-ext 50.00% <ø> (ø)
scuffle-h3-webtransport 0.00% <ø> (ø)
scuffle-http 22.48% <ø> (ø)
scuffle-metrics 66.39% <ø> (ø)
postcompile 79.36% <ø> (ø)
scuffle-pprof 100.00% <ø> (ø)
scuffle-settings 93.66% <100.00%> (+93.66%) ⬆️
scuffle-signal 100.00% <ø> (ø)

@lennartkloock lennartkloock marked this pull request as ready for review January 24, 2025 14:07
@TroyKomodo
Copy link
Member

?brawl merge

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 24, 2025

📌 Commit 123f15e has been approved and added to the merge queue.

Requested by: @TroyKomodo

Approved by: @TroyKomodo

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 24, 2025

⌛ Trying commit 123f15e with merge 6457685...

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 24, 2025

🎉 Build successful!
Completed in 8:14

Approved by: @TroyKomodo
Pushing 6457685 to main

@scuffle-brawl scuffle-brawl bot merged commit 6457685 into main Jan 24, 2025
11 checks passed
@scuffle-brawl scuffle-brawl bot deleted the lennart/CLOUD-8 branch January 24, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants