Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pprof: add test and docs #262

Merged
merged 5 commits into from
Jan 23, 2025
Merged

pprof: add test and docs #262

merged 5 commits into from
Jan 23, 2025

Conversation

lennartkloock
Copy link
Member

@lennartkloock lennartkloock commented Jan 21, 2025

  • Adds a simple test
  • Improves docs

CLOUD-11

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.07%. Comparing base (c06e35d) to head (3c9671c).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #262   +/-   ##
=======================================
  Coverage   63.07%   63.07%           
=======================================
  Files         202      202           
  Lines       15849    15849           
=======================================
  Hits         9996     9996           
  Misses       5853     5853           
Files with missing lines Coverage Δ
crates/pprof/src/cpu.rs 100.00% <ø> (ø)
crates/signal/src/lib.rs 100.00% <ø> (ø)
Components Coverage Δ
scuffle-aac 89.65% <ø> (ø)
scuffle-amf0 100.00% <ø> (ø)
scuffle-av1 98.66% <ø> (ø)
scuffle-batching 100.00% <ø> (ø)
scuffle-bootstrap 86.50% <ø> (ø)
scuffle-bytes-util 100.00% <ø> (ø)
scuffle-context 100.00% <ø> (ø)
scuffle-expgolomb 100.00% <ø> (ø)
scuffle-ffmpeg 31.81% <ø> (ø)
scuffle-flv 94.76% <ø> (ø)
scuffle-future-ext 50.00% <ø> (ø)
scuffle-h3-webtransport 0.00% <ø> (ø)
scuffle-http 22.48% <ø> (ø)
scuffle-metrics 66.39% <ø> (ø)
postcompile 79.36% <ø> (ø)
scuffle-pprof 100.00% <ø> (ø)
scuffle-settings 0.00% <ø> (ø)
scuffle-signal 100.00% <ø> (ø)

Copy link

cloudflare-workers-and-pages bot commented Jan 23, 2025

Deploying scuffle-docrs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3c9671c
Status: ✅  Deploy successful!
Preview URL: https://c5af4e5a.scuffle-docrs.pages.dev
Branch Preview URL: https://pr-262.scuffle-docrs.pages.dev

View logs

@TroyKomodo
Copy link
Member

We should add a crate doc example

//! let capture = cpu.capture(std::time::Duration::from_secs(10)).unwrap();
//!
//! // Write the profile to a file.
//! std::fs::write("capture.pprof", capture).unwrap();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps also show some go pprof tool commands for generating a flame graph of the capture

@TroyKomodo
Copy link
Member

?brawl merge

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 23, 2025

📌 Commit 3c9671c has been approved and added to the merge queue.

Requested by: @TroyKomodo

Approved by: @TroyKomodo

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 23, 2025

⌛ Trying commit 3c9671c with merge b5bcf37...

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 23, 2025

🎉 Build successful!
Completed in 8:19

Approved by: @TroyKomodo
Pushing b5bcf37 to main

@scuffle-brawl scuffle-brawl bot merged commit b5bcf37 into main Jan 23, 2025
11 checks passed
@scuffle-brawl scuffle-brawl bot deleted the lennart/CLOUD-11 branch January 23, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants