Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update workspace files and rename crates #258

Merged
merged 14 commits into from
Jan 20, 2025

Conversation

lennartkloock
Copy link
Member

@lennartkloock lennartkloock commented Jan 20, 2025

  • Fixes workspace files and dependencies
  • Updates codecov file
  • Updates README

CLOUD-34

Copy link

cloudflare-workers-and-pages bot commented Jan 20, 2025

Deploying scuffle-docrs with  Cloudflare Pages  Cloudflare Pages

Latest commit: de6bd87
Status: ✅  Deploy successful!
Preview URL: https://e536fcdf.scuffle-docrs.pages.dev
Branch Preview URL: https://pr-258.scuffle-docrs.pages.dev

View logs

@lennartkloock lennartkloock marked this pull request as ready for review January 20, 2025 12:10
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.00%. Comparing base (fa14d64) to head (de6bd87).
Report is 22 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #258   +/-   ##
=======================================
  Coverage   63.00%   63.00%           
=======================================
  Files         202      202           
  Lines       15849    15849           
=======================================
  Hits         9985     9985           
  Misses       5864     5864           
Components Coverage Δ
scuffle-aac 89.65% <ø> (ø)
scuffle-amf0 100.00% <ø> (ø)
scuffle-av1 98.66% <ø> (ø)
scuffle-batching 100.00% <ø> (ø)
scuffle-bootstrap 86.50% <ø> (ø)
scuffle-bytes-util 100.00% <ø> (ø)
scuffle-context 100.00% <ø> (ø)
scuffle-expgolomb 100.00% <ø> (ø)
scuffle-ffmpeg 31.81% <ø> (ø)
scuffle-flv 94.76% <ø> (ø)
scuffle-future-ext 50.00% <ø> (ø)
scuffle-h3-webtransport 0.00% <ø> (ø)
scuffle-http 22.48% <ø> (ø)
scuffle-metrics 66.39% <ø> (ø)
postcompile 76.87% <ø> (ø)
scuffle-pprof 100.00% <ø> (ø)
scuffle-settings 0.00% <ø> (ø)
scuffle-signal 100.00% <ø> (ø)

@lennartkloock
Copy link
Member Author

Why does this suddenly fail? I didn't change anything and it passes locally

@TroyKomodo
Copy link
Member

I don't want to rename the other crates until I have gone through and cleaned them up.

@lennartkloock
Copy link
Member Author

I don't want to rename the other crates until I have gone through and cleaned them up.

okay I will revert that commit

@TroyKomodo
Copy link
Member

Can we not add them to the root toml and codecov components until they are ready too. I will update codecov in each clean up PR.

@TroyKomodo
Copy link
Member

?brawl merge

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 20, 2025

📌 Commit de6bd87 has been approved and added to the merge queue.

Requested by: @TroyKomodo

Approved by: @TroyKomodo

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 20, 2025

⌛ Trying commit de6bd87 with merge 0fba7e3...

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 20, 2025

🎉 Build successful!
Completed in 8:30

Approved by: @TroyKomodo
Pushing 0fba7e3 to main

@scuffle-brawl scuffle-brawl bot merged commit 0fba7e3 into main Jan 20, 2025
12 checks passed
@scuffle-brawl scuffle-brawl bot deleted the lennart/CLOUD-34 branch January 20, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants