-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scuffle-metrics: tests and docs #252
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
==========================================
+ Coverage 55.74% 62.77% +7.03%
==========================================
Files 195 196 +1
Lines 15850 15850
==========================================
+ Hits 8835 9950 +1115
+ Misses 7015 5900 -1115
... and 14 files with indirect coverage changes
|
081a2d5
to
e2a804c
Compare
a580388
to
2d3c5d8
Compare
1ee5a68
to
e75c1da
Compare
9e073f9
to
fb6afcf
Compare
Deploying scuffle-docrs with Cloudflare Pages
|
We should likely add an example using it with the We should add what the We are missing docs on the types under the Is there a way to fix the weird formatting here? We should add a doc example with using it with the bootstrap crate on the Missing some documentation on |
The derive macro also allows for renaming fields. https://pr-252.scuffle-docrs.pages.dev/scuffle_metrics/collector/struct.Collector the new function here talks about a https://pr-252.scuffle-docrs.pages.dev/scuffle_metrics/prometheus/struct.PrometheusExporter the links here do not embed, not sure if desired. perhaps link directly to the upstream docs.rs? |
e66aedc
to
fa3f3aa
Compare
?brawl merge |
📌 Commit 2e946bd has been approved and added to the merge queue. Requested by: @TroyKomodo Approved by: @TroyKomodo |
🎉 Build successful! Approved by: @TroyKomodo |
Closes CLOUD-6