Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flv crate refactor #250

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

flv crate refactor #250

wants to merge 2 commits into from

Conversation

TroyKomodo
Copy link
Member

@TroyKomodo TroyKomodo commented Jan 11, 2025

Refactors the FLV Crate adding support for the new enhanced spec and improving the usage and API docs.

CLOUD-27

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 73.33333% with 64 lines in your changes missing coverage. Please review.

Project coverage is 50.96%. Comparing base (4459e5e) to head (a59f045).

Current head a59f045 differs from pull request most recent head f387659

Please upload reports for the commit f387659 to get more accurate results.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/av1/src/config.rs 15.00% 17 Missing ⚠️
crates/flv/src/video.rs 69.64% 17 Missing ⚠️
crates/flv/src/macros.rs 27.27% 8 Missing ⚠️
crates/flv/src/avc.rs 66.66% 5 Missing ⚠️
crates/flv/src/audio.rs 84.61% 4 Missing ⚠️
crates/flv/src/tag.rs 82.60% 4 Missing ⚠️
crates/flv/src/header.rs 92.00% 2 Missing ⚠️
crates/transmuxer/src/codecs/aac.rs 0.00% 2 Missing ⚠️
crates/transmuxer/src/errors.rs 0.00% 2 Missing ⚠️
crates/flv/src/aac.rs 87.50% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
- Coverage   51.00%   50.96%   -0.05%     
==========================================
  Files         195      201       +6     
  Lines       15819    15816       -3     
==========================================
- Hits         8069     8061       -8     
- Misses       7750     7755       +5     
Files with missing lines Coverage Δ
crates/flv/src/file.rs 100.00% <100.00%> (ø)
crates/transmuxer/src/codecs/av1.rs 97.61% <ø> (ø)
crates/transmuxer/src/codecs/avc.rs 84.09% <ø> (ø)
crates/transmuxer/src/codecs/hevc.rs 97.87% <ø> (ø)
crates/transmuxer/src/define.rs 100.00% <ø> (ø)
crates/flv/src/aac.rs 87.50% <87.50%> (ø)
crates/flv/src/script.rs 92.85% <92.85%> (ø)
crates/transmuxer/src/lib.rs 94.02% <96.15%> (-0.17%) ⬇️
crates/flv/src/header.rs 92.00% <92.00%> (ø)
crates/transmuxer/src/codecs/aac.rs 93.22% <0.00%> (-3.28%) ⬇️
... and 7 more

... and 1 file with indirect coverage changes

Components Coverage Δ
scuffle-batching 100.00% <ø> (ø)
scuffle-bootstrap 53.96% <ø> (+1.34%) ⬆️
scuffle-context 100.00% <ø> (ø)
scuffle-ffmpeg 0.00% <ø> (ø)
scuffle-h3-webtransport 0.00% <ø> (ø)
scuffle-http 0.00% <ø> (ø)
scuffle-metrics 42.69% <ø> (ø)
scuffle-pprof 0.00% <ø> (ø)
scuffle-settings 0.00% <ø> (ø)
scuffle-signal 100.00% <ø> (ø)
postcompile 0.00% <ø> (ø)
scuffle-image-processor ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant