-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup scuffle-av1 header decoder #247
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
==========================================
+ Coverage 50.16% 51.00% +0.84%
==========================================
Files 195 195
Lines 15876 15819 -57
==========================================
+ Hits 7964 8069 +105
+ Misses 7912 7750 -162
... and 1 file with indirect coverage changes
|
?brawl merge |
📌 Commit 29a1175 has been approved and added to the merge queue. Requested by: @lennartkloock Approved by: @lennartkloock |
?brawl cancel I think you did this by mistake |
🚨 Cancelled CI run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments are not pointing to the right code lines because they didn't change so Github wouldn't let me choose them.
Moves av1 stuff into a new crate for av1 decoding, encoding & obu parsing. Improves test coverage on existing av1 parsing. Improves parse design making use of zero copy behaviour. Remove `scuffle_bytes_util::BytesCursorExt::remaining()` fn because it conflicts with an already existing more generic impl from `Bytes::Buf`.
?brawl merge |
📌 Commit 8a65ff6 has been approved and added to the merge queue. Requested by: @lennartkloock Approved by: @lennartkloock |
🎉 Build successful! Approved by: @lennartkloock |
Moves av1 stuff into a new crate for av1 decoding, encoding & obu parsing.
Improves test coverage on existing av1 parsing.
Improves parse design making use of zero copy behaviour.
Remove
scuffle_bytes_util::BytesCursorExt::remaining()
fn because it conflicts with an already existing more generic impl fromBytes::Buf
.CLOUD-25