Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup scuffle-av1 header decoder #247

Merged
merged 8 commits into from
Jan 13, 2025
Merged

cleanup scuffle-av1 header decoder #247

merged 8 commits into from
Jan 13, 2025

Conversation

TroyKomodo
Copy link
Member

@TroyKomodo TroyKomodo commented Jan 10, 2025

Moves av1 stuff into a new crate for av1 decoding, encoding & obu parsing.

Improves test coverage on existing av1 parsing.

Improves parse design making use of zero copy behaviour.

Remove scuffle_bytes_util::BytesCursorExt::remaining() fn because it conflicts with an already existing more generic impl from Bytes::Buf.

CLOUD-25

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 95.65217% with 9 lines in your changes missing coverage. Please review.

Project coverage is 51.00%. Comparing base (3ed7ebd) to head (13c625b).
Report is 9 commits behind head on main.

Current head 13c625b differs from pull request most recent head 8a65ff6

Please upload reports for the commit 8a65ff6 to get more accurate results.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/av1/src/obu/seq.rs 97.27% 4 Missing ⚠️
crates/mp4/src/boxes/types/av01.rs 0.00% 4 Missing ⚠️
crates/av1/src/obu/mod.rs 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
+ Coverage   50.16%   51.00%   +0.84%     
==========================================
  Files         195      195              
  Lines       15876    15819      -57     
==========================================
+ Hits         7964     8069     +105     
+ Misses       7912     7750     -162     
Files with missing lines Coverage Δ
crates/av1/src/config.rs 98.64% <100.00%> (+4.36%) ⬆️
crates/av1/src/obu/utils.rs 100.00% <100.00%> (ø)
crates/bytes-util/src/bit_write.rs 100.00% <100.00%> (ø)
crates/bytes-util/src/bytes_cursor.rs 100.00% <100.00%> (ø)
crates/flv/src/define.rs 62.50% <ø> (ø)
crates/flv/src/flv.rs 81.28% <ø> (ø)
crates/mp4/src/boxes/types/av1c.rs 100.00% <ø> (ø)
crates/transmuxer/src/codecs/av1.rs 97.61% <100.00%> (+0.11%) ⬆️
crates/transmuxer/src/define.rs 100.00% <ø> (ø)
crates/av1/src/obu/mod.rs 98.27% <93.33%> (+51.28%) ⬆️
... and 2 more

... and 1 file with indirect coverage changes

Components Coverage Δ
scuffle-batching 100.00% <ø> (ø)
scuffle-bootstrap 52.61% <ø> (ø)
scuffle-context 100.00% <ø> (ø)
scuffle-ffmpeg 0.00% <ø> (ø)
scuffle-h3-webtransport 0.00% <ø> (ø)
scuffle-http 0.00% <ø> (ø)
scuffle-metrics 42.69% <ø> (ø)
scuffle-pprof 0.00% <ø> (ø)
scuffle-settings 0.00% <ø> (ø)
scuffle-signal 100.00% <ø> (ø)
postcompile 0.00% <ø> (ø)
scuffle-image-processor ∅ <ø> (∅)

crates/av1/README.md Outdated Show resolved Hide resolved
crates/transmuxer/src/codecs/av1.rs Show resolved Hide resolved
crates/mp4/src/boxes/types/av01.rs Show resolved Hide resolved
@lennartkloock
Copy link
Member

?brawl merge

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 11, 2025

📌 Commit 29a1175 has been approved and added to the merge queue.

Requested by: @lennartkloock

Approved by: @lennartkloock

@TroyKomodo
Copy link
Member Author

?brawl cancel

I think you did this by mistake

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 11, 2025

🚨 Cancelled CI run

Copy link
Member

@lennartkloock lennartkloock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments are not pointing to the right code lines because they didn't change so Github wouldn't let me choose them.

crates/av1/src/obu/mod.rs Outdated Show resolved Hide resolved
crates/av1/src/config.rs Show resolved Hide resolved
crates/av1/src/obu/mod.rs Show resolved Hide resolved
crates/av1/src/obu/seq.rs Show resolved Hide resolved
crates/av1/src/obu/seq.rs Show resolved Hide resolved
TroyKomodo and others added 5 commits January 13, 2025 15:53
Moves av1 stuff into a new crate for av1 decoding, encoding & obu parsing.
Improves test coverage on existing av1 parsing.
Improves parse design making use of zero copy behaviour.
Remove `scuffle_bytes_util::BytesCursorExt::remaining()` fn because it
conflicts with an already existing more generic impl from `Bytes::Buf`.
@lennartkloock
Copy link
Member

?brawl merge

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 13, 2025

📌 Commit 8a65ff6 has been approved and added to the merge queue.

Requested by: @lennartkloock

Approved by: @lennartkloock

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 13, 2025

⌛ Trying commit 8a65ff6 with merge 4459e5e...

@scuffle-brawl
Copy link
Contributor

scuffle-brawl bot commented Jan 13, 2025

🎉 Build successful!
Completed in 8:29

Approved by: @lennartkloock
Pushing 4459e5e to main

@scuffle-brawl scuffle-brawl bot merged commit 4459e5e into main Jan 13, 2025
7 checks passed
@scuffle-brawl scuffle-brawl bot deleted the troy/av1 branch January 13, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants