Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: gradients and containers #76

Merged
merged 2 commits into from
Jan 31, 2023
Merged

style: gradients and containers #76

merged 2 commits into from
Jan 31, 2023

Conversation

mds1
Copy link
Contributor

@mds1 mds1 commented Jan 30, 2023 •
edited
Loading

Closes #22, open to feedback on styles since I'm no designer 😅

image

@netlify
Copy link

netlify bot commented Jan 30, 2023 •
edited
Loading

✅ Deploy Preview for earnest-cascaron-03dbfc ready!

Name Link
🔨 Latest commit c252deb
🔍 Latest deploy log https://app.netlify.com/sites/earnest-cascaron-03dbfc/deploys/63d852bef77adc0008d9bbeb
😎 Deploy Preview https://deploy-preview-76--earnest-cascaron-03dbfc.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mds1
mds1 commented Jan 30, 2023
View reviewed changes
styles/globals.css Outdated Show resolved Hide resolved
@mds1 mds1 force-pushed the gradient-container-ui branch from 492c997 to 220302f Compare January 30, 2023 22:26
alexkeating
alexkeating approved these changes Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@alexkeating alexkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, suggested a chakra native way to handle the changes, and the color looks fine.

styles/globals.css Show resolved Hide resolved
alexkeating
alexkeating reviewed Jan 30, 2023
View reviewed changes
styles/globals.css Outdated Show resolved Hide resolved
@mds1 mds1 mentioned this pull request Jan 30, 2023
Open
wildmolasses
wildmolasses approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@wildmolasses wildmolasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@wildmolasses wildmolasses merged commit 71a11b6 into main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkeating alexkeating alexkeating approved these changes

@wildmolasses wildmolasses wildmolasses approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: Gradient background
3 participants
@mds1 @wildmolasses @alexkeating