Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add relay #6

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Add relay #6

merged 4 commits into from
Jun 24, 2024

Conversation

garyghayrat
Copy link
Member

No description provided.

@garyghayrat garyghayrat requested a review from wildmolasses June 20, 2024 21:37
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 20, 2024
View reviewed changes
src/L2ArbitrumGovernorV2.sol
Comment on lines +161 to +163
function relay(address target, uint256 value, bytes calldata data) external payable virtual override onlyOwner {
Address.functionCallWithValue(target, data, value);
}

Check warning

Code scanning / Slither

Unused return Medium

L2ArbitrumGovernorV2.relay(address,uint256,bytes) ignores return value by Address.functionCallWithValue(target,data,value)
wildmolasses
wildmolasses approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@wildmolasses wildmolasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

garyghayrat and others added 2 commits June 24, 2024 10:36
@github-actions GitHub Actions
Copy link

Coverage after merging add-relay into main will be

16.22%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   L2ArbitrumGovernorV2.sol50%100%38.46%57.14%100, 109, 118, 128–129, 182, 33, 70, 80
src/lib/governance/extensions
   GovernorCountingFractionalUpgradeable.sol1.12%0%10%0%100–101, 113–115, 122–124, 131–133, 172, 174–175, 175, 175–176, 179–182, 189, 189, 189–190, 190, 190–191, 193–194, 194, 194–195, 195, 195–196, 198–199, 199, 199–200, 200, 200–201, 203–204, 204, 204, 207, 207, 207–208, 212–215, 219, 219, 219–220, 223, 227–228, 228, 228–229, 231, 231, 231–232, 234, 234, 234–235, 237, 239, 67, 85, 92

@wildmolasses wildmolasses merged commit 9e0992f into main Jun 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wildmolasses wildmolasses wildmolasses approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garyghayrat @wildmolasses