Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flexible-voting #3

Merged
merged 7 commits into from
Jun 20, 2024
Merged

Add flexible-voting #3

merged 7 commits into from
Jun 20, 2024

Conversation

garyghayrat
Copy link
Member

  • Install OZ-contracts-upgradeable@f960f47
  • Add GovernorInvalidVoteParams error to custom GovernorCountingFractionalUpgradeable.
  • Use the custom GovernorCountingFractionalUpgradeable in L2ArbitrumGovernorV2

@wildmolasses wildmolasses changed the base branch from setup-fix-ci to setup June 20, 2024 15:14
@wildmolasses wildmolasses changed the base branch from setup to main June 20, 2024 15:18
apbendi and others added 4 commits June 20, 2024 11:24
@apbendi @garyghayrat
Assemble an initial Governor from appropriate extensions with overrides
d782323
@apbendi @garyghayrat
Set up test harness with fork test and proxy setup
86c0463
@apbendi @garyghayrat
Create base deployer script & script to deploy implementation
8fc50bc 
Create an inheritable Governor deploy script and test suite

Add license

Explicitly override base script run method

Lower optimization runs for contract size limitations

Add Arb RPC url to CI env

Decrease coverage threshold temporarily

Add GovernorCountingFractionalUpgradeable.sol from OZ f960f47

Use OZ Upgradeable@f960f47, use and add error to `GovernorCountingFractionalUpgradeable.sol`

Lower coverage threshold temporarily
@garyghayrat
Remove duplicate lines
559a19b
@garyghayrat garyghayrat force-pushed the add-GovernorCountingFractionalUpgradeable-manually branch from 3970cf0 to 559a19b Compare June 20, 2024 15:28
@wildmolasses wildmolasses mentioned this pull request Jun 20, 2024
Open
@github-actions GitHub Actions
Copy link

Coverage after merging add-GovernorCountingFractionalUpgradeable-manually into main will be

13.70%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   L2ArbitrumGovernorV2.sol37.50%100%16.67%50%108, 117, 127–128, 138, 148, 32, 69, 79, 99
src/lib/governance/extensions
   GovernorCountingFractionalUpgradeable.sol1.12%0%10%0%100–101, 113–115, 122–124, 131–133, 172, 174–175, 175, 175–176, 179–182, 189, 189, 189–190, 190, 190–191, 193–194, 194, 194–195, 195, 195–196, 198–199, 199, 199–200, 200, 200–201, 203–204, 204, 204, 207, 207, 207–208, 212–215, 219, 219, 219–220, 223, 227–228, 228, 228–229, 231, 231, 231–232, 234, 234, 234–235, 237, 239, 67, 85, 92

@wildmolasses wildmolasses self-requested a review June 20, 2024 15:51
wildmolasses
wildmolasses approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@wildmolasses wildmolasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wildmolasses wildmolasses merged commit 1213be6 into main Jun 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wildmolasses wildmolasses wildmolasses approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garyghayrat @wildmolasses @apbendi