Purge unittest?

[rcomer]

🚀 Pull Request

Description

I learned of these tools to help convert unittest tests to pytest-style tests

• unittest2pytest
• pytestify

So obviously I wanted to see what happens if you point them at cf_units! The udunits tests needed a little manual intervention, because the pattern

with pytest.raises(SomeError) as thing:

gives you a different thing to

with self.assertRaises(SomeError) as thing:

Otherwise, this was remarkably painless.

The final commit just gets rid of the pattern import cf_units as unit from one test module. I assume that was a hangover from when cf_units was taken out of the iris.unit module.

[pp-mo]

Respect for wading through all of this !
Some tiny suggestions, but basically all good !

[rcomer]

Thanks @pp-mo, I've addressed your comments. I'm at a loss what to do about Codacy's objection though.

[pp-mo]

@rcomer I'm at a loss what to do about Codacy's objection though.

I think it is because 'self' is unused in this method.
So I suppose it "wants" you to remove it from the signature + add "@staticmethod"
But I don't know whether PyTest would take kindly to that or not.
If not, you can just add a line with "self" on it, to evaluate but (presumably) do nothing.

[rcomer]

I tried removing that method entirely, and I couldn't see any change in the test output. 🤷‍♀️

[pp-mo]

Thanks @rcomer.
Not fun work, but very needed !