-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming module part 2. #13
Conversation
Looks like this needs rebasing. |
@rhattersley not anymore 😉 |
I did a quick grep for "iris" and "unit>" and it threw up a couple of things:
|
Is |
Yeah, seems OK. |
@@ -17,4 +17,7 @@ | |||
|
|||
__version__ = '0.0.1' | |||
|
|||
from .unit import * | |||
from .cf_units import * | |||
from .cf_units import (CALENDAR_STANDARD, CALENDARS, UT_NAMES, UT_DEFINITION, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhattersley should I those to __all__
in cf_units.py
or is this OK?
@rhattersley this time I tried to be very careful with the renaming and I believe we should be OK now. I also ran File "cf_units.py", line 1961, in cf_units.cf_units.Unit.date2num
Failed example:
u.date2num(datetime.datetime(1970, 1, 1, 5))
Expected:
5.00000000372529
Got:
5.0000000037252903 But I don't think that this precision is an issue. |
@rhattersley I want to start adding the tests (#2), but I want to avoid adding them and then re-naming everything. So I am waiting for this one to start the test migration. Do you think this PR is OK to go? |
It's close enough. 😁 |
Should Fix #12