Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add notes for next time
Browse files Browse the repository at this point in the history
rcomer committed Jun 28, 2023
1 parent 95f0e10 commit f0b65fa
Showing 3 changed files with 10 additions and 3 deletions.
9 changes: 8 additions & 1 deletion cf_units/_udunits2_parser/README.md
Original file line number Diff line number Diff line change
@@ -24,7 +24,14 @@ Please commit the changed parser at the same time as any
changes to the grammar being proposed so that the two can remain in synch.


### Testing the gammar
### Updating the ANTLR version

The above script downloads a Java Jar which should be the same version as
antlr4-python3-runtime specified in the python requirements. Once these have
been updated, run [the script](compile.py) to regenerate the parser.


### Testing the grammar

An extensive set of tests exist to confirm that the parser produces equivalent results
to the UDUNITS-2 reference implementation.
2 changes: 1 addition & 1 deletion requirements/cf-units.yml
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@ dependencies:
- numpy

# core dependencies
- antlr-python-runtime 4.11.1.*
- antlr-python-runtime 4.11.1.* # To update this, see cf_units/_udunits2_parser/README.md
- cftime>=1.2
- numpy
- udunits2
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
@@ -35,7 +35,7 @@ version = attr: cf_units.__version__
[options]
include_package_data = True
install_requires =
antlr4-python3-runtime ==4.11.1
antlr4-python3-runtime ==4.11.1 # To update this, see cf_units/_udunits2_parser/README.md
cftime >=1.2
jinja2
numpy

0 comments on commit f0b65fa

Please sign in to comment.