Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fornberg(2020) weights based on hermite-based finite difference #14

Merged
merged 7 commits into from
Feb 2, 2022

Conversation

yewalenikhil65
Copy link
Contributor

same PR from SciML/DiffEqOperators.jl#501 and also #13

@ChrisRackauckas
Copy link
Member

@xtalax review?

@yewalenikhil65
Copy link
Contributor Author

hey @ChrisRackauckas
@xtalax reviewed partially on DiffEqOperator.jl here
I would like to work on extending this a bit in actually solving PDE, but currently caught up in some other work. I will get back to it late this month.
Till then this PR is good to be to merge as it won't break anything.

@xtalax
Copy link
Member

xtalax commented Feb 2, 2022

Sorry about the delay, looks good to me

@yewalenikhil65
Copy link
Contributor Author

Sorry about the delay, looks good to me

@xtalax I see new some changes from my last commits in fornberg file. i will do same, resolve some conflicts and re-submit new commits

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #14 (d71125e) into master (de64d60) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #14   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           8       8           
  Lines         413     427   +14     
======================================
- Misses        413     427   +14     
Impacted Files Coverage Δ
src/discretization/fornberg.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de64d60...d71125e. Read the comment docs.

forgot earlier
@yewalenikhil65
Copy link
Contributor Author

@xtalax Done from my side for this PR !

@ChrisRackauckas ChrisRackauckas merged commit 3310e14 into SciML:master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants