🔀 정적 폼 생성 제작 #78

Ethen1264 · 2025-01-18T14:58:54Z

💡 배경 및 개요

정적 폼 생성 제작

📃 작업내용

컴포넌트 제작
다이나믹 폼 기능 제작

Summary by CodeRabbit

새로운 기능
- 동적 양식 생성 기능 추가
- 다양한 유형의 질문 옵션 (문장, 체크박스, 드롭다운, 다중 선택, 이미지) 지원
- 양식 섹션 추가 및 삭제 기능 구현
버그 수정
- 양식 구성 요소의 일관성 및 사용성 개선
개선 사항
- 아이콘 및 UI 컴포넌트 모듈화
- 양식 상태 관리 최적화

coderabbitai · 2025-01-18T14:59:01Z

Walkthrough

이 풀 리퀘스트는 폼 생성 기능을 위한 새로운 React 컴포넌트와 관련 유틸리티를 추가합니다. 주요 변경 사항은 폼 생성 페이지, 다양한 입력 옵션 컴포넌트, 아이콘, 그리고 폼 상태 관리를 위한 타입 정의를 포함합니다. 이러한 변경은 애플리케이션의 폼 생성 워크플로우를 개선하고 확장성을 높이는 데 중점을 둡니다.

Changes

파일	변경 요약
`src/app/(pages)/create-form/page.tsx`	새로운 페이지 컴포넌트 추가
`src/entities/create-form/ui/*`	다양한 폼 관련 UI 컴포넌트 생성
`src/shared/assets/icons/*`	새로운 아이콘 컴포넌트 추가
`src/shared/types/create-form/type.ts`	폼 관련 TypeScript 인터페이스 정의
`src/views/create-form/ui/createForm/index.tsx`	폼 생성 메인 컴포넌트 구현

Sequence Diagram

sequenceDiagram
    participant User
    participant CreateFormPage
    participant CreateForm
    participant FormContainer
    participant FormTypeSelect

    User->>CreateFormPage: 페이지 접속
    CreateFormPage->>CreateForm: 렌더링
    CreateForm->>User: 폼 생성 인터페이스 표시
    User->>CreateForm: 새 질문 추가
    CreateForm->>FormContainer: 질문 컨테이너 생성
    FormContainer->>FormTypeSelect: 폼 타입 선택
    User->>FormTypeSelect: 폼 타입 선택
    FormContainer->>User: 선택된 타입의 입력 옵션 표시

Suggested labels

📬 Type: API, ✨ Feature: Form Creation, 🚀 Enhancement: UI Components

Suggested reviewers

answad
happytaeyoon

Poem

🐰 폼 만드는 토끼의 노래 🎵

컴포넌트 쌓아 폼을 짓고
아이콘 그리며 길을 열어
동적인 입력의 세계에서
사용자의 꿈을 그려내네
코드로 피어난 창의력! 🌈

Finishing Touches

📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 18

🧹 Nitpick comments (11)

src/shared/types/create-form/type.ts (2)
4-8: 타입 안정성 개선이 필요합니다.

value와 label의 타입을 더 구체적으로 정의하면 좋을 것 같습니다.
export interface Option {
-  value: string;
-  label?: string;
+  value: 'SENTENCE' | 'CHECKBOX' | 'DROPDOWN' | 'MULTIPLE' | 'IMAGE';
+  label?: '문장형' | '체크박스' | '드롭다운' | '객관식' | '이미지';
  icon?: ReactNode;
}
10-16: 폼 유효성 검증 제약조건이 필요합니다.

questions 배열의 길이나 title의 최대 길이 등에 대한 제약조건을 추가하면 좋을 것 같습니다.
export interface FormValues {
  questions: {
-    title: string;
+    title: string & { maxLength?: 100 };
    formType: string;
    options: Option[];
+    maxQuestions?: number;
  }[];
}
src/views/create-form/model/selectOptionData.tsx (1)
10-16: 상수 데이터 구조 개선이 필요합니다.

옵션 데이터를 더 유지보수하기 쉽게 구조화하면 좋을 것 같습니다.
+export const FORM_TYPES = {
+  SENTENCE: 'SENTENCE',
+  CHECKBOX: 'CHECKBOX',
+  DROPDOWN: 'DROPDOWN',
+  MULTIPLE: 'MULTIPLE',
+  IMAGE: 'IMAGE',
+} as const;

+export const FORM_LABELS = {
+  [FORM_TYPES.SENTENCE]: '문장형',
+  [FORM_TYPES.CHECKBOX]: '체크박스',
+  [FORM_TYPES.DROPDOWN]: '드롭다운',
+  [FORM_TYPES.MULTIPLE]: '객관식',
+  [FORM_TYPES.IMAGE]: '이미지',
+} as const;

export const selectOptionData: Option[] = [
-  { value: 'SENTENCE', label: '문장형', icon: <Typing /> },
+  { value: FORM_TYPES.SENTENCE, label: FORM_LABELS[FORM_TYPES.SENTENCE], icon: <Typing /> },
  // ... 나머지 옵션들도 동일하게 수정
];
src/entities/create-form/index.tsx (1)
1-10: 타입 내보내기 및 명명된 내보내기 고려

현재 구현은 기능적으로는 문제가 없으나, 다음과 같은 개선사항을 고려해보세요:

컴포넌트와 관련된 타입들도 함께 내보내면 좋을 것 같습니다.

Tree-shaking을 위해 named export 사용을 고려해보세요.
- export { default as CheckBoxOption } from './ui/CheckBoxOption';
+ export { CheckBoxOption, type CheckBoxOptionProps } from './ui/CheckBoxOption';
src/entities/create-form/ui/PictureOption/index.tsx (2)
15-19: 접근성 및 유효성 검사 개선 필요

입력 필드에 다음 사항들을 추가하는 것이 좋습니다:

aria-label 속성

최대 길이 제한

입력 유효성 검사
 <input
   {...register(`questions.${index}.options.${optionIndex}.value`)}
   placeholder="문장을 입력해주세요."
+  aria-label={`사진 옵션 ${optionIndex + 1}`}
+  maxLength={100}
   className="w-[60%] text-body4 text-black"
 />
21-23: 버튼 접근성 개선 필요

삭제 버튼에 접근성 속성을 추가해주세요:
 <button 
   type="button" 
   onClick={() => remove(optionIndex)}
+  aria-label={`옵션 ${optionIndex + 1} 삭제`}
 >
   <XMark />
 </button>
src/shared/assets/icons/FormPicture.tsx (2)
3-6: Props 인터페이스에 color 속성 추가 필요

재사용성을 높이기 위해 fill 색상을 props로 받는 것이 좋습니다.
 interface Props {
   width?: string;
   height?: string;
+  color?: string;
 }
18-19: 하드코딩된 색상값 개선 필요

현재 하드코딩된 #909090 색상을 props로 받아 유연하게 처리하는 것이 좋습니다.
-        fill="#909090"
+        fill={color || '#909090'}
src/widgets/create-form/ui/FormContainer/index.tsx (1)
50-91: 컴포넌트 맵 로직 최적화가 필요합니다.

현재 컴포넌트 맵이 매 렌더링마다 재생성되고 있습니다. 이를 컴포넌트 외부로 이동하여 성능을 개선할 수 있습니다.
+const COMPONENT_MAP: Record<string, React.FC<{
+  fields: any;
+  remove: any;
+  register: any;
+  index: number;
+}>> = {
+  SENTENCE: TextOption,
+  CHECKBOX: CheckBoxOption,
+  DROPDOWN: DropDownOption,
+  MULTIPLE: MultipleChoiceOption,
+  IMAGE: PictureOption,
+};

 const FormContainer = ({
   options,
   formRemove,
   index,
   register,
   setValue,
   control,
 }: Props) => {
-  const componentMap: Record<string, JSX.Element | null> = {
-    SENTENCE: (
-      <TextOption
-        fields={fields}
-        remove={remove}
-        register={register}
-        index={index}
-      />
-    ),
-    // ... other components
-  };
src/entities/create-exhibition/ui/ExpoInput/index.tsx (1)
Line range hint 114-123: 필드 추가 시 타입 안전성 강화가 필요합니다.

append 함수에 전달되는 객체의 타입을 명시적으로 정의하여 타입 안전성을 개선할 수 있습니다.
+type FieldData = {
+  title: string;
+  startedAt: string;
+  endedAt: string;
+  category?: 'CHOICE';
+};

 <AddItemButton
   onClick={() =>
-    append({
+    append<FieldData>({
       title: '',
       startedAt: '',
       endedAt: '',
       ...(fieldName === 'trainings' ? { category: 'CHOICE' } : {}),
     })
   }
 />
src/shared/assets/icons/ArrowUp.tsx (1)
3-3: 타입 정의를 추가해주세요.

컴포넌트의 props에 대한 타입 정의가 누락되었습니다. 타입 안정성을 위해 다음과 같이 인터페이스를 추가하는 것을 추천드립니다:
+interface ArrowUpProps {
+  fill?: string;
+}

-const ArrowUp = ({ fill = '#121212' }) => {
+const ArrowUp = ({ fill = '#121212' }: ArrowUpProps) => {

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7683573 and 6a9383a.

📒 Files selected for processing (33)

src/app/(pages)/create-form/page.tsx (1 hunks)
src/entities/create-exhibition/ui/ExpoInput/index.tsx (3 hunks)
src/entities/create-form/index.tsx (1 hunks)
src/entities/create-form/ui/CheckBoxOption/index.tsx (1 hunks)
src/entities/create-form/ui/CreateFormButton/index.tsx (1 hunks)
src/entities/create-form/ui/DeleteButton/index.tsx (1 hunks)
src/entities/create-form/ui/DropDownOption/index.tsx (1 hunks)
src/entities/create-form/ui/FormTitle/index.tsx (1 hunks)
src/entities/create-form/ui/FormTypeSelect/index.tsx (1 hunks)
src/entities/create-form/ui/MultipleChoiceOption/index.tsx (1 hunks)
src/entities/create-form/ui/PictureOption/index.tsx (1 hunks)
src/entities/create-form/ui/RequiredToggle/index.tsx (1 hunks)
src/entities/create-form/ui/TextOption/index.tsx (1 hunks)
src/shared/assets/icons/ArrowUp.tsx (2 hunks)
src/shared/assets/icons/CheckBoxIcon.tsx (1 hunks)
src/shared/assets/icons/DropDown.tsx (1 hunks)
src/shared/assets/icons/FormPicture.tsx (1 hunks)
src/shared/assets/icons/MultipleChoic.tsx (1 hunks)
src/shared/assets/icons/Trash.tsx (2 hunks)
src/shared/assets/icons/Typing.tsx (1 hunks)
src/shared/assets/icons/index.mdx (2 hunks)
src/shared/assets/icons/index.tsx (1 hunks)
src/shared/assets/svg/Circle.tsx (1 hunks)
src/shared/assets/svg/Squere.tsx (1 hunks)
src/shared/assets/svg/index.tsx (1 hunks)
src/shared/types/create-form/type.ts (1 hunks)
src/shared/ui/AddItemButton/index.tsx (1 hunks)
src/shared/ui/ToggleButton/index.tsx (1 hunks)
src/shared/ui/index.tsx (1 hunks)
src/views/create-form/index.tsx (1 hunks)
src/views/create-form/model/selectOptionData.tsx (1 hunks)
src/views/create-form/ui/createForm/index.tsx (1 hunks)
src/widgets/create-form/ui/FormContainer/index.tsx (1 hunks)

✅ Files skipped from review due to trivial changes (7)

src/views/create-form/index.tsx
src/shared/assets/svg/Circle.tsx
src/shared/assets/icons/DropDown.tsx
src/app/(pages)/create-form/page.tsx
src/shared/assets/icons/Typing.tsx
src/shared/assets/svg/Squere.tsx
src/shared/assets/icons/CheckBoxIcon.tsx

🔇 Additional comments (6)

src/shared/assets/svg/index.tsx (1)

2-3: 내보내기 패턴이 일관성 있게 작성되었습니다.

배럴(barrel) 패턴을 사용하여 SVG 컴포넌트들을 깔끔하게 내보내고 있습니다. 이는 좋은 방식입니다.

src/shared/ui/index.tsx (1)

7-8: 변경사항이 적절합니다.

공유 UI 컴포넌트의 내보내기가 일관된 패턴을 따르고 있습니다.

src/shared/assets/icons/Trash.tsx (1)

Line range hint 3-14: 구현이 잘 되었습니다!

color prop을 통한 동적 색상 처리가 잘 구현되어 있습니다.
src/views/create-form/ui/createForm/index.tsx (1)

65-69: 빈 폼 추가 시 유효성 검사 필요

새로운 폼 필드 추가 시 기본값에 대한 유효성 검사가 필요합니다.
 <CreateFormButton
   onClick={() =>
-    append({ title: '', formType: 'SENTENCE', options: [] })
+    append({
+      title: '',
+      formType: 'SENTENCE',
+      options: [],
+    }, {
+      shouldValidate: true
+    })
   }
 />
src/shared/assets/icons/index.mdx (1)

26-29: 아이콘 추가가 적절히 이루어졌습니다.

폼 기능에 필요한 새로운 아이콘들이 잘 추가되었습니다.

Also applies to: 71-74

src/shared/assets/icons/ArrowUp.tsx (1)

14-14: 동적 fill 속성 구현이 잘 되었습니다!

props를 통해 fill 색상을 동적으로 변경할 수 있도록 구현한 것이 좋습니다. 이를 통해 컴포넌트의 재사용성이 향상되었습니다.

coderabbitai · 2025-01-18T15:05:13Z

src/shared/assets/svg/index.tsx

@@ -1 +1,3 @@
 export { default as Logo } from './Logo';
+export { default as Squere } from './Squere';


⚠️ Potential issue

'Squere' 컴포넌트 이름의 오타를 수정해 주세요.

'Squere'는 'Square'의 오타로 보입니다. 컴포넌트 이름과 파일 이름을 모두 올바른 영어 철자로 수정하는 것이 좋겠습니다.

다음과 같이 수정해 주세요:

-export { default as Squere } from './Squere'; +export { default as Square } from './Square';

관련 파일명도 Squere.tsx에서 Square.tsx로 변경이 필요합니다.

Committable suggestion skipped: line range outside the PR's diff.

coderabbitai · 2025-01-18T15:05:13Z

src/entities/create-form/ui/RequiredToggle/index.tsx

+const RequiredToggle = () => {
+  return (
+    <label className="flex items-center gap-6">
+      <p className="text-caption2 text-black">필수</p>
+      <ToggleButton />
+    </label>
+  );
+};


🛠️ Refactor suggestion

상태 관리 및 접근성 개선이 필요합니다.

현재 구현에는 다음과 같은 문제가 있습니다:

ToggleButton의 상태를 제어하거나 읽을 수 없습니다

onChange 핸들러가 누락되었습니다

접근성 속성이 부족합니다

다음과 같이 수정하는 것을 제안합니다:

-const RequiredToggle = () => { +interface Props { + isRequired: boolean; + onChange: (isRequired: boolean) => void; +} + +const RequiredToggle = ({ isRequired, onChange }: Props) => { return ( - <label className="flex items-center gap-6"> + <label className="flex items-center gap-6" role="switch" aria-checked={isRequired}> <p className="text-caption2 text-black">필수</p> - <ToggleButton /> + <ToggleButton checked={isRequired} onChange={onChange} /> </label> ); };

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

const RequiredToggle = () => {

return (

<label className="flex items-center gap-6">

<p className="text-caption2 text-black">필수</p>

<ToggleButton />

</label>

);

};

interface Props {

isRequired: boolean;

onChange: (isRequired: boolean) => void;

}

const RequiredToggle = ({ isRequired, onChange }: Props) => {

return (

<label className="flex items-center gap-6" role="switch" aria-checked={isRequired}>

<p className="text-caption2 text-black">필수</p>

<ToggleButton checked={isRequired} onChange={onChange} />

</label>

);

};

coderabbitai · 2025-01-18T15:05:14Z

src/entities/create-form/ui/DeleteButton/index.tsx

+const DeleteButton = ({ onClick }: Props) => {
+  return (
+    <button onClick={onClick} className="flex items-center gap-2">
+      <Trash color="#BDBDBD" />
+      <p className="text-caption2 text-gray-300">버리기</p>
+    </button>
+  );
+};


🛠️ Refactor suggestion

버튼의 접근성과 상호작용 상태를 개선해야 합니다.

다음 사항들이 개선되어야 합니다:

button 타입 속성 누락

접근성 속성 누락

hover/focus 상태 스타일 누락

다음과 같이 수정하는 것을 제안합니다:

const DeleteButton = ({ onClick }: Props) => { return ( <button + type="button" + aria-label="항목 삭제" - className="flex items-center gap-2" + className="flex items-center gap-2 hover:opacity-80 focus:outline-none focus:ring-2 focus:ring-gray-300 rounded" onClick={onClick} > <Trash color="#BDBDBD" /> <p className="text-caption2 text-gray-300">버리기</p> </button> ); };

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

const DeleteButton = ({ onClick }: Props) => {

return (

<button onClick={onClick} className="flex items-center gap-2">

<Trash color="#BDBDBD" />

<p className="text-caption2 text-gray-300">버리기</p>

</button>

);

};

const DeleteButton = ({ onClick }: Props) => {

return (

<button

type="button"

aria-label="항목 삭제"

className="flex items-center gap-2 hover:opacity-80 focus:outline-none focus:ring-2 focus:ring-gray-300 rounded"

onClick={onClick}

>

<Trash color="#BDBDBD" />

<p className="text-caption2 text-gray-300">버리기</p>

</button>

);

};

coderabbitai · 2025-01-18T15:05:14Z

src/shared/ui/AddItemButton/index.tsx

+const AddItemButton = ({ onClick }: AddItemButtonProps) => (
+  <button
+    type="button"
+    className="mx-auto flex items-center gap-5"
+    onClick={onClick}
+  >
+    <Plus fill="#448FFF" />
+    <div className="text-body3 text-main-600">추가하기</div>
+  </button>
+);


🛠️ Refactor suggestion

접근성과 일관성 개선이 필요합니다.

다음 사항들이 개선되어야 합니다:

접근성 속성 누락

hover/focus 상태 스타일 누락

텍스트에 div 대신 p 태그 사용 필요 (일관성)

다음과 같이 수정하는 것을 제안합니다:

const AddItemButton = ({ onClick }: AddItemButtonProps) => ( <button type="button" + aria-label="항목 추가" - className="mx-auto flex items-center gap-5" + className="mx-auto flex items-center gap-5 hover:opacity-80 focus:outline-none focus:ring-2 focus:ring-main-600 rounded" onClick={onClick} > <Plus fill="#448FFF" /> - <div className="text-body3 text-main-600">추가하기</div> + <p className="text-body3 text-main-600">추가하기</p> </button> );

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

const AddItemButton = ({ onClick }: AddItemButtonProps) => (

<button

type="button"

className="mx-auto flex items-center gap-5"

onClick={onClick}

>

<Plus fill="#448FFF" />

<div className="text-body3 text-main-600">추가하기</div>

</button>

);

const AddItemButton = ({ onClick }: AddItemButtonProps) => (

<button

type="button"

aria-label="항목 추가"

className="mx-auto flex items-center gap-5 hover:opacity-80 focus:outline-none focus:ring-2 focus:ring-main-600 rounded"

onClick={onClick}

>

<Plus fill="#448FFF" />

<p className="text-body3 text-main-600">추가하기</p>

</button>

);

coderabbitai · 2025-01-18T15:05:14Z

src/entities/create-form/ui/CreateFormButton/index.tsx

+    <button
+      onClick={onClick}
+      className="flex w-fit items-center gap-[10px] rounded-sm bg-main-300 px-6 py-3"
+    >
+      <Plus fill="#FFF" />
+      <p className="text-h4 text-white">추가하기</p>
+    </button>
+  );


🛠️ Refactor suggestion

접근성과 유지보수성 개선이 필요합니다.

버튼에 aria-label이 없습니다.

텍스트가 하드코딩되어 있습니다.

<button onClick={onClick} + aria-label="폼 항목 추가" className="flex w-fit items-center gap-[10px] rounded-sm bg-main-300 px-6 py-3" > <Plus fill="#FFF" /> - <p className="text-h4 text-white">추가하기</p> + <p className="text-h4 text-white">{FORM_BUTTON_LABELS.ADD}</p> </button>

상수 파일 생성을 추천드립니다:

// constants.ts export const FORM_BUTTON_LABELS = { ADD: '추가하기' } as const;

coderabbitai · 2025-01-18T15:05:15Z

src/shared/assets/icons/MultipleChoic.tsx

+import React from 'react';
+
+const MultipleChoic = () => {
+  return (
+    <svg
+      xmlns="http://www.w3.org/2000/svg"
+      width="24"
+      height="24"
+      viewBox="0 0 24 24"
+      fill="none"
+    >
+      <path
+        d="M12 2.25C10.0716 2.25 8.18657 2.82183 6.58319 3.89317C4.97982 4.96451 3.73013 6.48726 2.99218 8.26884C2.25422 10.0504 2.06114 12.0108 2.43735 13.9021C2.81355 15.7934 3.74215 17.5307 5.10571 18.8943C6.46928 20.2579 8.20656 21.1865 10.0979 21.5627C11.9892 21.9389 13.9496 21.7458 15.7312 21.0078C17.5127 20.2699 19.0355 19.0202 20.1068 17.4168C21.1782 15.8134 21.75 13.9284 21.75 12C21.7473 9.41498 20.7192 6.93661 18.8913 5.10872C17.0634 3.28084 14.585 2.25273 12 2.25ZM12 20.25C10.3683 20.25 8.77326 19.7661 7.41655 18.8596C6.05984 17.9531 5.00242 16.6646 4.378 15.1571C3.75358 13.6496 3.5902 11.9908 3.90853 10.3905C4.22685 8.79016 5.01259 7.32015 6.16637 6.16637C7.32016 5.01259 8.79017 4.22685 10.3905 3.90852C11.9909 3.59019 13.6497 3.75357 15.1571 4.37799C16.6646 5.00242 17.9531 6.05984 18.8596 7.41655C19.7661 8.77325 20.25 10.3683 20.25 12C20.2475 14.1873 19.3775 16.2843 17.8309 17.8309C16.2843 19.3775 14.1873 20.2475 12 20.25ZM16.2806 9.96937C16.3504 10.039 16.4057 10.1217 16.4434 10.2128C16.4812 10.3038 16.5006 10.4014 16.5006 10.5C16.5006 10.5986 16.4812 10.6962 16.4434 10.7872C16.4057 10.8783 16.3504 10.961 16.2806 11.0306L12.5306 14.7806C12.461 14.8504 12.3783 14.9057 12.2872 14.9434C12.1962 14.9812 12.0986 15.0006 12 15.0006C11.9014 15.0006 11.8038 14.9812 11.7128 14.9434C11.6218 14.9057 11.539 14.8504 11.4694 14.7806L7.71938 11.0306C7.57865 10.8899 7.49959 10.699 7.49959 10.5C7.49959 10.301 7.57865 10.1101 7.71938 9.96937C7.86011 9.82864 8.05098 9.74958 8.25 9.74958C8.44903 9.74958 8.6399 9.82864 8.78063 9.96937L12 13.1897L15.2194 9.96937C15.289 9.89964 15.3718 9.84432 15.4628 9.80658C15.5538 9.76884 15.6514 9.74941 15.75 9.74941C15.8486 9.74941 15.9462 9.76884 16.0372 9.80658C16.1283 9.84432 16.211 9.89964 16.2806 9.96937Z"
+        fill="#909090"
+      />
+    </svg>
+  );
+};
+
+export default MultipleChoic;


🛠️ Refactor suggestion

컴포넌트 이름 및 재사용성 개선 필요

파일명이 "MultipleChoic"에서 "MultipleChoice"로 수정되어야 합니다.

FormPicture 컴포넌트와 같이 width, height, color props를 추가하면 재사용성이 향상될 것 같습니다.

-const MultipleChoic = () => { +interface Props { + width?: string; + height?: string; + color?: string; +} + +const MultipleChoice = ({ width = '24', height = '24', color = '#909090' }: Props) => { return ( <svg xmlns="http://www.w3.org/2000/svg" - width="24" - height="24" + width={width} + height={height} viewBox="0 0 24 24" fill="none" > <path d="M12 2.25C10.0716 2.25 8.18657 2.82183 6.58319 3.89317C4.97982 4.96451 3.73013 6.48726 2.99218 8.26884C2.25422 10.0504 2.06114 12.0108 2.43735 13.9021C2.81355 15.7934 3.74215 17.5307 5.10571 18.8943C6.46928 20.2579 8.20656 21.1865 10.0979 21.5627C11.9892 21.9389 13.9496 21.7458 15.7312 21.0078C17.5127 20.2699 19.0355 19.0202 20.1068 17.4168C21.1782 15.8134 21.75 13.9284 21.75 12C21.7473 9.41498 20.7192 6.93661 18.8913 5.10872C17.0634 3.28084 14.585 2.25273 12 2.25ZM12 20.25C10.3683 20.25 8.77326 19.7661 7.41655 18.8596C6.05984 17.9531 5.00242 16.6646 4.378 15.1571C3.75358 13.6496 3.5902 11.9908 3.90853 10.3905C4.22685 8.79016 5.01259 7.32015 6.16637 6.16637C7.32016 5.01259 8.79017 4.22685 10.3905 3.90852C11.9909 3.59019 13.6497 3.75357 15.1571 4.37799C16.6646 5.00242 17.9531 6.05984 18.8596 7.41655C19.7661 8.77325 20.25 10.3683 20.25 12C20.2475 14.1873 19.3775 16.2843 17.8309 17.8309C16.2843 19.3775 14.1873 20.2475 12 20.25ZM16.2806 9.96937C16.3504 10.039 16.4057 10.1217 16.4434 10.2128C16.4812 10.3038 16.5006 10.4014 16.5006 10.5C16.5006 10.5986 16.4812 10.6962 16.4434 10.7872C16.4057 10.8783 16.3504 10.961 16.2806 11.0306L12.5306 14.7806C12.461 14.8504 12.3783 14.9057 12.2872 14.9434C12.1962 14.9812 12.0986 15.0006 12 15.0006C11.9014 15.0006 11.8038 14.9812 11.7128 14.9434C11.6218 14.9057 11.539 14.8504 11.4694 14.7806L7.71938 11.0306C7.57865 10.8899 7.49959 10.699 7.49959 10.5C7.49959 10.301 7.57865 10.1101 7.71938 9.96937C7.86011 9.82864 8.05098 9.74958 8.25 9.74958C8.44903 9.74958 8.6399 9.82864 8.78063 9.96937L12 13.1897L15.2194 9.96937C15.289 9.89964 15.3718 9.84432 15.4628 9.80658C15.5538 9.76884 15.6514 9.74941 15.75 9.74941C15.8486 9.74941 15.9462 9.76884 16.0372 9.80658C16.1283 9.84432 16.211 9.89964 16.2806 9.96937Z" - fill="#909090" + fill={color} /> </svg> ); }; -export default MultipleChoic; +export default MultipleChoice;

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

import React from 'react';

const MultipleChoic = () => {

return (

<svg

xmlns="http://www.w3.org/2000/svg"

width="24"

height="24"

viewBox="0 0 24 24"

fill="none"

>

<path

d="M12 2.25C10.0716 2.25 8.18657 2.82183 6.58319 3.89317C4.97982 4.96451 3.73013 6.48726 2.99218 8.26884C2.25422 10.0504 2.06114 12.0108 2.43735 13.9021C2.81355 15.7934 3.74215 17.5307 5.10571 18.8943C6.46928 20.2579 8.20656 21.1865 10.0979 21.5627C11.9892 21.9389 13.9496 21.7458 15.7312 21.0078C17.5127 20.2699 19.0355 19.0202 20.1068 17.4168C21.1782 15.8134 21.75 13.9284 21.75 12C21.7473 9.41498 20.7192 6.93661 18.8913 5.10872C17.0634 3.28084 14.585 2.25273 12 2.25ZM12 20.25C10.3683 20.25 8.77326 19.7661 7.41655 18.8596C6.05984 17.9531 5.00242 16.6646 4.378 15.1571C3.75358 13.6496 3.5902 11.9908 3.90853 10.3905C4.22685 8.79016 5.01259 7.32015 6.16637 6.16637C7.32016 5.01259 8.79017 4.22685 10.3905 3.90852C11.9909 3.59019 13.6497 3.75357 15.1571 4.37799C16.6646 5.00242 17.9531 6.05984 18.8596 7.41655C19.7661 8.77325 20.25 10.3683 20.25 12C20.2475 14.1873 19.3775 16.2843 17.8309 17.8309C16.2843 19.3775 14.1873 20.2475 12 20.25ZM16.2806 9.96937C16.3504 10.039 16.4057 10.1217 16.4434 10.2128C16.4812 10.3038 16.5006 10.4014 16.5006 10.5C16.5006 10.5986 16.4812 10.6962 16.4434 10.7872C16.4057 10.8783 16.3504 10.961 16.2806 11.0306L12.5306 14.7806C12.461 14.8504 12.3783 14.9057 12.2872 14.9434C12.1962 14.9812 12.0986 15.0006 12 15.0006C11.9014 15.0006 11.8038 14.9812 11.7128 14.9434C11.6218 14.9057 11.539 14.8504 11.4694 14.7806L7.71938 11.0306C7.57865 10.8899 7.49959 10.699 7.49959 10.5C7.49959 10.301 7.57865 10.1101 7.71938 9.96937C7.86011 9.82864 8.05098 9.74958 8.25 9.74958C8.44903 9.74958 8.6399 9.82864 8.78063 9.96937L12 13.1897L15.2194 9.96937C15.289 9.89964 15.3718 9.84432 15.4628 9.80658C15.5538 9.76884 15.6514 9.74941 15.75 9.74941C15.8486 9.74941 15.9462 9.76884 16.0372 9.80658C16.1283 9.84432 16.211 9.89964 16.2806 9.96937Z"

fill="#909090"

/>

</svg>

);

};

export default MultipleChoic;

import React from 'react';

interface Props {

width?: string;

height?: string;

color?: string;

}

const MultipleChoice = ({ width = '24', height = '24', color = '#909090' }: Props) => {

return (

<svg

xmlns="http://www.w3.org/2000/svg"

width={width}

height={height}

viewBox="0 0 24 24"

fill="none"

>

<path

d="M12 2.25C10.0716 2.25 8.18657 2.82183 6.58319 3.89317C4.97982 4.96451 3.73013 6.48726 2.99218 8.26884C2.25422 10.0504 2.06114 12.0108 2.43735 13.9021C2.81355 15.7934 3.74215 17.5307 5.10571 18.8943C6.46928 20.2579 8.20656 21.1865 10.0979 21.5627C11.9892 21.9389 13.9496 21.7458 15.7312 21.0078C17.5127 20.2699 19.0355 19.0202 20.1068 17.4168C21.1782 15.8134 21.75 13.9284 21.75 12C21.7473 9.41498 20.7192 6.93661 18.8913 5.10872C17.0634 3.28084 14.585 2.25273 12 2.25ZM12 20.25C10.3683 20.25 8.77326 19.7661 7.41655 18.8596C6.05984 17.9531 5.00242 16.6646 4.378 15.1571C3.75358 13.6496 3.5902 11.9908 3.90853 10.3905C4.22685 8.79016 5.01259 7.32015 6.16637 6.16637C7.32016 5.01259 8.79017 4.22685 10.3905 3.90852C11.9909 3.59019 13.6497 3.75357 15.1571 4.37799C16.6646 5.00242 17.9531 6.05984 18.8596 7.41655C19.7661 8.77325 20.25 10.3683 20.25 12C20.2475 14.1873 19.3775 16.2843 17.8309 17.8309C16.2843 19.3775 14.1873 20.2475 12 20.25ZM16.2806 9.96937C16.3504 10.039 16.4057 10.1217 16.4434 10.2128C16.4812 10.3038 16.5006 10.4014 16.5006 10.5C16.5006 10.5986 16.4812 10.6962 16.4434 10.7872C16.4057 10.8783 16.3504 10.961 16.2806 11.0306L12.5306 14.7806C12.461 14.8504 12.3783 14.9057 12.2872 14.9434C12.1962 14.9812 12.0986 15.0006 12 15.0006C11.9014 15.0006 11.8038 14.9812 11.7128 14.9434C11.6218 14.9057 11.539 14.8504 11.4694 14.7806L7.71938 11.0306C7.57865 10.8899 7.49959 10.699 7.49959 10.5C7.49959 10.301 7.57865 10.1101 7.71938 9.96937C7.86011 9.82864 8.05098 9.74958 8.25 9.74958C8.44903 9.74958 8.6399 9.82864 8.78063 9.96937L12 13.1897L15.2194 9.96937C15.289 9.89964 15.3718 9.84432 15.4628 9.80658C15.5538 9.76884 15.6514 9.74941 15.75 9.74941C15.8486 9.74941 15.9462 9.76884 16.0372 9.80658C16.1283 9.84432 16.211 9.89964 16.2806 9.96937Z"

fill={color}

/>

</svg>

);

};

export default MultipleChoice;

coderabbitai · 2025-01-18T15:05:16Z

src/views/create-form/ui/createForm/index.tsx

+  const onSubmit = (data: FormValues) => {
+    const formattedData = data.questions.map((question) => ({
+      title: question.title,
+      formType: question.formType,
+      jsonData: JSON.stringify(
+        question.options.reduce(
+          (acc, option, index) => {
+            acc[(index + 1).toString()] = option.value;
+            return acc;
+          },
+          {} as Record<string, string>,
+        ),
+      ),
+    }));
+
+    console.log(formattedData);
+    // 서버에 전송하는 코드 추가 가능
+  };


🛠️ Refactor suggestion

onSubmit 함수 개선 필요

프로덕션 코드에서는 console.log를 제거해야 합니다.

서버 제출 로직 구현이 필요합니다.

에러 처리가 누락되어 있습니다.

const onSubmit = (data: FormValues) => { + try { const formattedData = data.questions.map((question) => ({ title: question.title, formType: question.formType, jsonData: JSON.stringify( question.options.reduce( (acc, option, index) => { acc[(index + 1).toString()] = option.value; return acc; }, {} as Record<string, string>, ), ), })); - console.log(formattedData); - // 서버에 전송하는 코드 추가 가능 + // TODO: API 호출 구현 + return await submitForm(formattedData); + } catch (error) { + // TODO: 에러 처리 구현 + console.error('폼 제출 중 오류 발생:', error); + throw error; + } };

Committable suggestion skipped: line range outside the PR's diff.

coderabbitai · 2025-01-18T15:05:16Z

src/entities/create-form/ui/FormTypeSelect/index.tsx

+      <button
+        type="button"
+        onClick={() => setIsOpen(!isOpen)}
+        className="flex w-full items-center justify-between rounded-md border-1 border-solid border-gray-100 bg-white px-3 py-[10px]"
+      >
+        <div className="flex items-center">
+          {selectedOption?.icon && (
+            <span className="mr-2">{selectedOption.icon}</span>
+          )}
+          <span className="text-h5 text-gray-500">{selectedOption?.label}</span>
+        </div>
+        {isOpen ? <ArrowUp fill="#909090" /> : <ArrowDown fill="#909090" />}
+      </button>


🛠️ Refactor suggestion

드롭다운 접근성 개선이 필요합니다.

키보드 네비게이션과 ARIA 속성이 누락되어 있습니다. 스크린 리더 사용자를 위해 다음 사항들을 추가해주세요:

aria-expanded

aria-haspopup

aria-label

키보드 이벤트 핸들러

<button type="button" onClick={() => setIsOpen(!isOpen)} + aria-expanded={isOpen} + aria-haspopup="listbox" + aria-label="폼 타입 선택" + onKeyDown={(e) => { + if (e.key === 'Enter' || e.key === ' ') { + setIsOpen(!isOpen); + } + }} className="flex w-full items-center justify-between rounded-md border-1 border-solid border-gray-100 bg-white px-3 py-[10px]" >

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

<button

type="button"

onClick={() => setIsOpen(!isOpen)}

className="flex w-full items-center justify-between rounded-md border-1 border-solid border-gray-100 bg-white px-3 py-[10px]"

>

<div className="flex items-center">

{selectedOption?.icon && (

<span className="mr-2">{selectedOption.icon}</span>

)}

<span className="text-h5 text-gray-500">{selectedOption?.label}</span>

</div>

{isOpen ? <ArrowUp fill="#909090" /> : <ArrowDown fill="#909090" />}

</button>

<button

type="button"

onClick={() => setIsOpen(!isOpen)}

aria-expanded={isOpen}

aria-haspopup="listbox"

aria-label="폼 타입 선택"

onKeyDown={(e) => {

if (e.key === 'Enter' || e.key === ' ') {

setIsOpen(!isOpen);

}

}}

className="flex w-full items-center justify-between rounded-md border-1 border-solid border-gray-100 bg-white px-3 py-[10px]"

>

<div className="flex items-center">

{selectedOption?.icon && (

<span className="mr-2">{selectedOption.icon}</span>

)}

<span className="text-h5 text-gray-500">{selectedOption?.label}</span>

</div>

{isOpen ? <ArrowUp fill="#909090" /> : <ArrowDown fill="#909090" />}

</button>

coderabbitai · 2025-01-18T15:05:16Z

src/entities/create-form/ui/FormTypeSelect/index.tsx

+      {isOpen && (
+        <ul className="absolute z-30 mt-1 flex w-full flex-col items-center gap-[10px] rounded-md border-1 border-solid border-gray-100 bg-white py-[30px] shadow-lg">
+          {options.map((option) => (
+            <li
+              key={option.value}
+              onClick={() => {
+                setSelectedOption(option);
+                setValue(`questions.${index}.formType`, option.value);
+                setIsOpen(false);
+              }}
+              className="flex w-full cursor-pointer items-center justify-center p-2 text-h5 text-gray-500 hover:bg-gray-100"
+            >
+              {option.icon && <span className="mr-2">{option.icon}</span>}
+              {option.label}
+            </li>
+          ))}
+        </ul>
+      )}


🛠️ Refactor suggestion

드롭다운 목록의 접근성과 키보드 인터랙션 개선이 필요합니다.

드롭다운 목록에 적절한 ARIA 속성과 키보드 네비게이션이 필요합니다.

-{isOpen && ( +{isOpen && ( + <ul + role="listbox" + aria-label="폼 타입 옵션" + className="absolute z-30 mt-1 flex w-full flex-col items-center gap-[10px] rounded-md border-1 border-solid border-gray-100 bg-white py-[30px] shadow-lg" + > {options.map((option) => ( <li key={option.value} + role="option" + aria-selected={selectedOption?.value === option.value} + tabIndex={0} onClick={() => { setSelectedOption(option); setValue(`questions.${index}.formType`, option.value); setIsOpen(false); }} + onKeyDown={(e) => { + if (e.key === 'Enter' || e.key === ' ') { + setSelectedOption(option); + setValue(`questions.${index}.formType`, option.value); + setIsOpen(false); + } + }} className="flex w-full cursor-pointer items-center justify-center p-2 text-h5 text-gray-500 hover:bg-gray-100" >

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

{isOpen && (

<ul className="absolute z-30 mt-1 flex w-full flex-col items-center gap-[10px] rounded-md border-1 border-solid border-gray-100 bg-white py-[30px] shadow-lg">

{options.map((option) => (

<li

key={option.value}

onClick={() => {

setSelectedOption(option);

setValue(`questions.${index}.formType`, option.value);

setIsOpen(false);

}}

className="flex w-full cursor-pointer items-center justify-center p-2 text-h5 text-gray-500 hover:bg-gray-100"

>

{option.icon && <span className="mr-2">{option.icon}</span>}

{option.label}

</li>

))}

</ul>

)}

{isOpen && (

<ul

role="listbox"

aria-label="폼 타입 옵션"

className="absolute z-30 mt-1 flex w-full flex-col items-center gap-[10px] rounded-md border-1 border-solid border-gray-100 bg-white py-[30px] shadow-lg"

>

{options.map((option) => (

<li

key={option.value}

role="option"

aria-selected={selectedOption?.value === option.value}

tabIndex={0}

onClick={() => {

setSelectedOption(option);

setValue(`questions.${index}.formType`, option.value);

setIsOpen(false);

}}

onKeyDown={(e) => {

if (e.key === 'Enter' || e.key === ' ') {

setSelectedOption(option);

setValue(`questions.${index}.formType`, option.value);

setIsOpen(false);

}

}}

className="flex w-full cursor-pointer items-center justify-center p-2 text-h5 text-gray-500 hover:bg-gray-100"

>

{option.icon && <span className="mr-2">{option.icon}</span>}

{option.label}

</li>

))}

</ul>

)}

coderabbitai · 2025-01-18T15:05:16Z

src/widgets/create-form/ui/FormContainer/index.tsx

+  const renderOptionComponent = () => {
+    return selectedOption?.value
+      ? componentMap[selectedOption.value] || null
+      : null;
+  };


🛠️ Refactor suggestion

renderOptionComponent 함수의 타입 안전성 개선이 필요합니다.

선택된 옵션의 value가 유효한 컴포넌트 타입인지 확인하는 타입 가드가 필요합니다.

+type ComponentType = keyof typeof COMPONENT_MAP; +const isValidComponentType = (value: string): value is ComponentType => { + return value in COMPONENT_MAP; +}; const renderOptionComponent = () => { - return selectedOption?.value - ? componentMap[selectedOption.value] || null - : null; + if (!selectedOption?.value || !isValidComponentType(selectedOption.value)) { + return null; + } + const Component = COMPONENT_MAP[selectedOption.value]; + return ( + <Component + fields={fields} + remove={remove} + register={register} + index={index} + /> + ); };

Committable suggestion skipped: line range outside the PR's diff.

Ethen1264 added 11 commits January 17, 2025 20:34

🎨Update: AddItemButton move to shared

49e3f0d

🎨Add: FormTitle

6b08abc

🎨Add: deleteButton

6a0ebe0

🎨Add: RequiredToggle:

b5876df

🎨Add: FormTypeSelect

76d3baa

🎨Add: option components

1938dfd

🎨Add: etc components

e1b734e

🎨Add: FormContainer

a3d5fc0

🎨Add: form container

d0722f4

🎨 Add: CreateFormButton

801842d

✨Add: dainamic form function

6a9383a

Ethen1264 added ✨ Feature 신규 기능 🎨 Type: Publishing 디자인 구현 labels Jan 18, 2025

Ethen1264 self-assigned this Jan 18, 2025

Ethen1264 requested a review from happytaeyoon as a code owner January 18, 2025 14:58

coderabbitai bot reviewed Jan 18, 2025

View reviewed changes

happytaeyoon approved these changes Jan 18, 2025

View reviewed changes

Ethen1264 merged commit c6ca3c9 into develop Jan 19, 2025
2 checks passed

coderabbitai bot mentioned this pull request Jan 21, 2025

🔀 정적 폼 디자인 1차 변경 #80

Merged

Ethen1264 deleted the feature/dynamic-form branch January 23, 2025 12:33

coderabbitai bot mentioned this pull request Feb 4, 2025

🔀 박람회 신청 폼 페이지 변경 #91

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🔀 정적 폼 생성 제작 #78

🔀 정적 폼 생성 제작 #78

Ethen1264 commented Jan 18, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 18, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

coderabbitai bot Jan 18, 2025

coderabbitai bot Jan 18, 2025

coderabbitai bot Jan 18, 2025

coderabbitai bot Jan 18, 2025

coderabbitai bot Jan 18, 2025

coderabbitai bot Jan 18, 2025

coderabbitai bot Jan 18, 2025

coderabbitai bot Jan 18, 2025

coderabbitai bot Jan 18, 2025

coderabbitai bot Jan 18, 2025

		@@ -1 +1,3 @@
		export { default as Logo } from './Logo';
		export { default as Squere } from './Squere';

🔀 정적 폼 생성 제작 #78

🔀 정적 폼 생성 제작 #78

Conversation

Ethen1264 commented Jan 18, 2025 • edited by coderabbitai bot Loading

💡 배경 및 개요

📃 작업내용

Summary by CodeRabbit

coderabbitai bot commented Jan 18, 2025 • edited Loading

Walkthrough

Changes

Sequence Diagram

Suggested labels

Suggested reviewers

Poem

Finishing Touches

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Jan 18, 2025

Choose a reason for hiding this comment

coderabbitai bot Jan 18, 2025

Choose a reason for hiding this comment

coderabbitai bot Jan 18, 2025

Choose a reason for hiding this comment

coderabbitai bot Jan 18, 2025

Choose a reason for hiding this comment

coderabbitai bot Jan 18, 2025

Choose a reason for hiding this comment

coderabbitai bot Jan 18, 2025

Choose a reason for hiding this comment

coderabbitai bot Jan 18, 2025

Choose a reason for hiding this comment

coderabbitai bot Jan 18, 2025

Choose a reason for hiding this comment

coderabbitai bot Jan 18, 2025

Choose a reason for hiding this comment

coderabbitai bot Jan 18, 2025

Choose a reason for hiding this comment

Ethen1264 commented Jan 18, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 18, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)