[tsconfig] Update for TypeScript 5.8 #4503
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbranch
requested review from
madskristensen and
hyperupcall
as code owners
|
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
for more information, see https://pre-commit.ci
jakebailey
reviewed
Feb 27, 2025
Comment on lines
+294
to
+295
| "erasableSyntaxOnly": { | ||
| "description": "Do not allow runtime constructs that are not part of ECMAScript.", |
There was a problem hiding this comment.
I think this all should be matching the declarations around it, e.g. the $comment is missing. (Same with the other options added in the PR)
There was a problem hiding this comment.
I don’t really know what $comment is for, and lots of newer property declarations don’t have it 🤷
|
Is this ready to be merged? |
|
@madskristensen yes, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates for TypeScript 5.8