Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marshal: add missing padding to unencrypted keys #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fasmide
Copy link

@fasmide fasmide commented Oct 26, 2021

Based off @andredurao 's work found in issue #10 :)

@codeviking
Copy link

I just wanted to bump this PR, as I separately ran into the same issue and resolved it by using @fasmide's fork.

@pquerna any chance this could get merged in? I've verified that it works (at least for ed25519 keys).

@pquerna
Copy link
Contributor

pquerna commented Jan 27, 2022

sorry, I don't work at Okta and don't have permissions on this repository -- @phoebeyu-okta ?

@codeviking
Copy link

@pquerna Oops. Sorry about that. I saw your name in the commit log and chose to ping you.

Thanks for looping someone else in!

@achuchev
Copy link

I want to bump this PR. Due to the issue fixed by this PR, some OpenSSH clients do not work with SSH keys generated by this library.

Do you plan to merge it?

Copy link
Contributor

@asitchakraborti-okta asitchakraborti-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it will be good to add a comment on the selection of that blocksize, probably referring to openssh doc/code. Also, it will be good to add a test case on that scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants