Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use debug utils during instance creation #1098

Merged
merged 2 commits into from
Jan 21, 2024

Conversation

jherico
Copy link
Contributor

@jherico jherico commented Jan 11, 2024

The VulkanDebug.h header is referencing the old VK_EXT_debug_report message callback signature, which no longer exists. I've updated the declaration to match the VK_EXT_debug_utils signature and changed the name in VulkanDebug.cpp to match.

Additionally, if validation is enabled, it should be applied to instance creation as well as everything after that. This is allowed by VK_EXT_debug_utils by passing the VkDebugUtilsMessengerCreateInfoEXT structure in the pNext chain of the VkInstanceCreateInfo structure, which the base example code now does.

@SaschaWillems
Copy link
Owner

Thank you very much for your contribution.

base/VulkanDebug.cpp Show resolved Hide resolved
base/vulkanexamplebase.cpp Show resolved Hide resolved
@SaschaWillems
Copy link
Owner

This looks good time. Thank you very much 👍🏻

@SaschaWillems SaschaWillems merged commit e37a333 into SaschaWillems:master Jan 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants