Use debug utils during instance creation #1098
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
VulkanDebug.h
header is referencing the oldVK_EXT_debug_report
message callback signature, which no longer exists. I've updated the declaration to match theVK_EXT_debug_utils
signature and changed the name inVulkanDebug.cpp
to match.Additionally, if validation is enabled, it should be applied to instance creation as well as everything after that. This is allowed by
VK_EXT_debug_utils
by passing theVkDebugUtilsMessengerCreateInfoEXT
structure in thepNext
chain of theVkInstanceCreateInfo
structure, which the base example code now does.