Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite training and inference code to more modern pytorch, add some functionalities and models #20

Merged
merged 42 commits into from
Jul 18, 2021

Conversation

annaproxy
Copy link
Collaborator

@annaproxy annaproxy commented Jul 14, 2021

  • Added pytorch dataset and dataloader instead of manual random sampler
  • Use torch.optim instead of manual update
  • Dataset now uses beginning of speech as well as end of speech tag
  • Added nn.RNN instead of manual RNN
  • Added embeddings (currently still one-hot, but could be made trainable) instead of manual one-hot
  • Add comprehensive Dutch dictionary for pretraining
  • Split notebook into two notebooks: one for training, one for inference
  • CUDA can now be used for training and inference
  • Add pre-trained Dutch model

@annaproxy annaproxy added the enhancement New feature or request label Jul 14, 2021
@annaproxy annaproxy requested a review from Sasafrass July 14, 2021 23:46
app/api/slang.py Show resolved Hide resolved
app/ml_models/rnn/data_tools.py Outdated Show resolved Hide resolved
app/ml_models/rnn/data_tools.py Show resolved Hide resolved
app/ml_models/rnn/data_tools.py Outdated Show resolved Hide resolved
app/ml_models/rnn/data_tools.py Outdated Show resolved Hide resolved
app/ml_models/rnn/train.py Outdated Show resolved Hide resolved
app/ml_models/rnn/train.py Outdated Show resolved Hide resolved
app/ml_models/rnn/train.py Outdated Show resolved Hide resolved
app/ml_models/rnn/train.py Outdated Show resolved Hide resolved
app/ml_models/rnn/train.py Show resolved Hide resolved
annaproxy and others added 3 commits July 16, 2021 18:47
annaproxy and others added 4 commits July 17, 2021 08:05
raoulg
raoulg previously approved these changes Jul 17, 2021
@raoulg
Copy link
Collaborator

raoulg commented Jul 17, 2021

Added some formatting stuff in a review branch

@raoulg raoulg dismissed their stale review July 17, 2021 11:51

when running flask run and generating a word, I get an error on this branch. Not sure if that is some db update stuff (tried running flask db update) or something in the code

@annaproxy
Copy link
Collaborator Author

Anything else? If no, can I merge? uwu

@Sasafrass
Copy link
Owner

when running flask run and generating a word, I get an error on this branch. Not sure if that is some db update stuff (tried running flask db update) or something in the code

Issue is addressed in latest hotfix.

@Sasafrass
Copy link
Owner

Anything else? If no, can I merge? uwu

Nope, everything LGTM now! Happy merging!

Copy link
Owner

@Sasafrass Sasafrass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annaproxy annaproxy merged commit fe46d87 into master Jul 18, 2021
@Sasafrass Sasafrass deleted the anna-clean-notebook branch July 18, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants