Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NUI] Support ColorVisual CutoutPolicy.Outside #6594

Open
wants to merge 1 commit into
base: DevelNUI
Choose a base branch
from

Conversation

hinohie
Copy link
Contributor

@hinohie hinohie commented Jan 21, 2025

Let we support ColorVisualCutoutPolicyType.CutoutOutsideWithCornerRadius and ColorVisualCutoutPolicyType.CutoutOutside.

It will be used when we want to make inner shadow effect by ColorVisual.

Inner Shadow
image

Fake neumorphism
image

@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 2, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.ColorVisualCutoutPolicyType Tizen.NUI.ColorVisualCutoutPolicyType::CutoutOutside

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.ColorVisualCutoutPolicyType Tizen.NUI.ColorVisualCutoutPolicyType::CutoutOutsideWithCornerRadius

@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 2, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.ColorVisualCutoutPolicyType Tizen.NUI.ColorVisualCutoutPolicyType::CutoutOutside

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.ColorVisualCutoutPolicyType Tizen.NUI.ColorVisualCutoutPolicyType::CutoutOutsideWithCornerRadius

@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 2, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.ColorVisualCutoutPolicyType Tizen.NUI.ColorVisualCutoutPolicyType::CutoutOutside

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.ColorVisualCutoutPolicyType Tizen.NUI.ColorVisualCutoutPolicyType::CutoutOutsideWithCornerRadius

@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 2, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.ColorVisualCutoutPolicyType Tizen.NUI.ColorVisualCutoutPolicyType::CutoutOutside

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.ColorVisualCutoutPolicyType Tizen.NUI.ColorVisualCutoutPolicyType::CutoutOutsideWithCornerRadius

@dongsug-song
Copy link
Contributor

Hello, There was a diff and conflict between DevelNUI and main, causing difficulties in integrating NUI. Therefore, a hard reset was performed on DevelNUI. As a result, the pull requests (https://github.com/Samsung/TizenFX/pulls) in DevelNUI are now conflicting. To resolve this, you can go to the specific PR, where you will see an error indicating a conflict. You can then use the command line to resolve the conflict.
or Here is another example. This one updates everything below the topmost patch, leaving only the topmost patch unchanged.

git fetch upstream  
git rebase --onto=upstream/DevelNUI HEAD~1  
git push {current working branch} -f

I'm sorry for the inconvenience.
thank you.

Let we support `ColorVisualCutoutPolicyType.CutoutOutsideWithCornerRadius` and
`ColorVisualCutoutPolicyType.CutoutOutside`.

It will be used when we want to make inner shadow effect by `ColorVisual`.

Signed-off-by: Eunki, Hong <[email protected]>
@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 2, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.ColorVisualCutoutPolicyType Tizen.NUI.ColorVisualCutoutPolicyType::CutoutOutside

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.ColorVisualCutoutPolicyType Tizen.NUI.ColorVisualCutoutPolicyType::CutoutOutsideWithCornerRadius

Copy link
Contributor

@everLEEst everLEEst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants