Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NUI] Add Internal RequestLayout and OnReqeustLayout virtual method #6588

Open
wants to merge 1 commit into
base: DevelNUI
Choose a base branch
from

Conversation

everLEEst
Copy link
Contributor

When owner class modified and layout need to be changed, RequestLayout will be called, but there are no way to notify and perform specific actions on derived Layouts.
Use this virtual function by overriding will solve this request.

Description of Change

API Changes

  • ACR:

@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 1, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.LayoutItem::OnRequestLayout()

@everLEEst everLEEst changed the title [NUI] Add OnReqeustLayout virtual method for layout can modify action when it requested. [NUI] Add Internal RequestLayout and OnReqeustLayout virtual method Jan 17, 2025
@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 1, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.LayoutItem::OnRequestLayout(Tizen.NUI.LayoutItem)

@dongsug-song
Copy link
Contributor

Hello, There was a diff and conflict between DevelNUI and main, causing difficulties in integrating NUI. Therefore, a hard reset was performed on DevelNUI. As a result, the pull requests (https://github.com/Samsung/TizenFX/pulls) in DevelNUI are now conflicting. To resolve this, you can go to the specific PR, where you will see an error indicating a conflict. You can then use the command line to resolve the conflict.
or Here is another example. This one updates everything below the topmost patch, leaving only the topmost patch unchanged.

git fetch upstream  
git rebase --onto=upstream/DevelNUI HEAD~1  
git push {current working branch} -f

I'm sorry for the inconvenience.
thank you.

When owner class modified and layout need to be changed,
RequestLayout will be called, but there are no way to notify and perform
specific actions on derived Layouts.
Now RequestLayout intenrally pass the requester item and invoke
OnRequestLayout method.
Use this virtual function by overriding will solve this request.
@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 1, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.LayoutItem::OnRequestLayout(Tizen.NUI.LayoutItem)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants