Improve Button UI #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed the tooltip because we want readability. We want to make it quick and easy to know what the button is. We don't care about the version -- that's in the content manager, nor do we care about instructions, that's in the menu itself.
* Improved the UI of the button to be more consistent with the buttons around it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think most people can agree that right now the button within the road tool seems out of place and odd. Well I'm here to fix that!
I changed the tooltip to just say the mod name. This is for a couple reasons: 1) the tooltip is supposed to be a very very very short (like 3 words short) descriptor of what the button is. For example, the straight road says "Straight Road", curved says "Curved Road," the advisor says "Advisor," and so on. 2) there's no reason to display the mod version in the tooltip. If we need to find out, we should look at the Content Manager where every other mod's version is. 3) it was just really long. We don't need instructions in the tooltip; those can be in the menu itself or on the steam workshop page.
I removed the text of the button and replaced it with the icon of the selected option. This makes sense for various reasons. The major ones being: 1) consistency; it feels way more consistent with the other buttons and really fits in well, 2) appearance; imho, it looks a lot better, and 3) usability; it's quick and easy to identify if you've got any settings enabled the next time you go to build a road. Just glance and you recognize the icon, instead of having to read tiny text.
Hope this gets merged, I'd love to see these improvements implemented :)
P.S. I did not up the version, in case you'd want to do it.