-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added filtering module, also support loading from a single-column CSV of tickers #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change time output to minutes instead of seconds Add ability to print all results together an the end Output anomalous tickers to a results.txt file
opens anomalous tickers in Robinhood in a new browser window
Creates graphs for all tickers in results.txt Allows option for single ticker or tickers of your choice
Example results.txt file
change line numbers for controlling the script
Add/update descriptions grapher.py and openRobinhood.py
Fix formatting error
Provides option to save graphs to the figures directory or to print them to screen
Create figures dir if it doesn't exist
remove previous addition of printing anomalous results together at the end
Parallelization
Revert "Parallelization"
Add various functionality
Revert "Add various functionality "
This removes the unused finding function, and replaces it with the normal algorithm. Then, all the indexing through the Pandas Dataframes are refactored in preference for the faster Pandas calls.
Pandas branch
Remove additional /r in README
flask_freezer to generate the static page flask_server to host it yourself (dynamic stuff coming later) 6 month window
template.html for generating static page with website_generator dynamic.html for serving yourself with flask_server refactored globals to class variables in market_scanner print all results at end when running market_scanner line 34 fixes the off-by-1 bug (if it exists, will test it on Monday).
try to pull secret key from env var added default parameters, now these are set when you instantiate the object made exportList a class variable
example of filtering, grabbing tickers up to the 95th percentile of trading volume. Brings us down to ~5000 tickers
Closed
the loading can also easily be modified to make a list of tickers to ignore, a la #24 |
elizabethshirley
approved these changes
Aug 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, be sure to fix up the merge issues, and get them committed to Master soon. Big PRs are hard to navigate
working on merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stocklist_filter.py
does the filtering & outputs the tickers in a single-column CSVright now it just grabs tickers up to the 95th percentile of daily volume. Should probably filter on market cap (or weight volume by mcap)
main_func()
has a new parameter,doFilter
(False by default), that loadslist_of_tickers
fromfiltered_tickers.csv
when set to True