Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas Refactoring #33

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Pandas Refactoring #33

wants to merge 32 commits into from

Conversation

elizabethshirley
Copy link

@elizabethshirley elizabethshirley commented Aug 1, 2020

  • Refactors Pandas calls in market_scanner, improving readability, and in theory speeding up usage
  • Add a small exception handler, making debug easier
  • Add TDQM miniter assignment to improve loading bar performance on slow internet connections
  • Removes unused find_anomalies and renames find_anomalies_two to find_anomalies
  • Removes unnecessary days_between function
  • Inlines filtering of Pandas call, and put it all in one spot

NihilistPenguin and others added 27 commits July 31, 2020 01:51
Change time output to minutes instead of seconds
Add ability to print all results together an the end
Output anomalous tickers to a results.txt file
opens anomalous tickers in Robinhood in a new browser window
Creates graphs for all tickers in results.txt 
Allows option for single ticker or tickers of your choice
Example results.txt file
change line numbers for controlling the script
Add/update descriptions grapher.py and openRobinhood.py
Fix formatting error
Provides option to save graphs to the figures directory or to print them to screen
Create figures dir if it doesn't exist
remove previous addition of printing anomalous results together at the end
Revert "Add various functionality "
This removes the unused finding function, and replaces it with the
normal algorithm. Then, all the indexing through the Pandas Dataframes
are refactored in preference for the faster Pandas calls.
Remove additional /r in README
@c0sc0 c0sc0 mentioned this pull request Aug 1, 2020
@c0sc0
Copy link
Contributor

c0sc0 commented Aug 1, 2020

good stuff! merged it with my latest into #34

@elizabethshirley
Copy link
Author

@SamPom100 This cleanup should help considerably with readability

@Stjernex24
Copy link

Stjernex24 commented Aug 1, 2020

How can one input a volume based script onto the graph where it displays possible tops and bottom based on volume? Link below https://www.tradingview.com/script/MhlDpfdS-Volume-Flow-Indicator-LazyBear/?utm_source=amp-version&_gl=1*m8ofg2*_ga*ZnZtTk1WelBfOGV0R1Y0dExkdlJMc3FKMmRTdklPa1R1WFg2MzQ4TlRiRkU0aHJ5enJrYjVsUmRsOXN1V2pqdA..

@Stjernex24
Copy link

Stjernex24 commented Aug 1, 2020 via email

@elizabethshirley
Copy link
Author

How can one input a volume based script onto the graph where it displays possible tops and bottom based on volume? Link below https://www.tradingview.com/script/MhlDpfdS-Volume-Flow-Indicator-LazyBear/?utm_source=amp-version&_gl=1*m8ofg2*_ga*ZnZtTk1WelBfOGV0R1Y0dExkdlJMc3FKMmRTdklPa1R1WFg2MzQ4TlRiRkU0aHJ5enJrYjVsUmRsOXN1V2pqdA..

These should be put into the Issues segment

@Stjernex24
Copy link

Stjernex24 commented Aug 1, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants