Enable multithreading in synapse python client #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasyu888
changed the base branch from
develop
to
SYNR-1536-enable-multi-threads
thomasyu888
merged commit b938fea
into
Sage-Bionetworks:SYNR-1536-enable-multi-threads
3 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here, synapser is configured to disable multithreading in the synapse python client. Previously, when the R client was implemented with PythonEmbedInR, multithreading caused issues. Currently, it uses reticulate, which appears to support python multithreading, from digging through the issues on the reticulate repository. However, I did notice several examples of folks struggling with this on Windows, so that should be a priority for testing.
On a mac, I had no issues with downloading or uploading with multi threading enabled. It increased my download speed from ~14-15 MB/s to ~90 MB/s. I didn't test upload speed with multi threading disabled, but with it enabled the upload speed was ~110 MB/s.