-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(openchallenges): fix bugs related search dropdown filters on search page #2688
Conversation
This reverts commit 01ee477.
@tschaffter I am not sure if the changes in this pr will fix the flicking issue you encountered 🍀 |
libs/openchallenges/ui/src/lib/search-dropdown-filter/search-dropdown-filter.component.html
Show resolved
Hide resolved
libs/openchallenges/ui/src/lib/search-dropdown-filter/search-dropdown-filter.component.html
Outdated
Show resolved
Hide resolved
libs/openchallenges/challenge-search/src/lib/challenge-search.component.ts
Outdated
Show resolved
Hide resolved
libs/openchallenges/challenge-search/src/lib/challenge-search.component.ts
Outdated
Show resolved
Hide resolved
libs/openchallenges/ui/src/lib/search-dropdown-filter/search-dropdown-filter.component.html
Outdated
Show resolved
Hide resolved
If we disable loading animation, does the flickering behavior still exist? @tschaffter |
|
Changelogs
Preview
Disable loader animation
While the loading animation looks nice, a flickering behavior has been observed (see @tschaffter's message below), which is why this PR hides the animation.
Fix empty labels
b) Invalid selected values
Fix selected values not shown in UI
The selected values, if present, will always sit on the top of options, unless the values are unselected and reset by changing search term.