-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(openchallenges): implement input data type filter on challenge search page #2649
Conversation
…norepo into input-data-filter
Quality Gate passed for 'openchallenges-app'Issues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new component works as described.
How does the bug that you mention and are fixing in another PR affects the shipping of the present PR?
- Do you plan to merge the second PR into this present PR, then merge it to
main
? - Do you want to merge this PR into
main
first, then merge the second PR tomain
?- This is OK if you consider that the first PR could potentially be shipped to prod without the fix. We could also wait for the fix to be ready before merging the two PRs consecutively.
One concept that may help here and for sure in the future are "feature flags". Here, we could show/hide the new UI component using a boolean flag in the app config. Lets discuss this strategy next time we meet!
Since this bug has already been there on the |
The filter should now be able to search the EDAM data concepts and be used to filter challenges.
Changelogs
Preview
There is a bug I notice for the search dropdown filter - tracked #2648, and will be fixed in a future pr.