Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openchallenges): implement input data type filter on challenge search page #2649

Merged
merged 10 commits into from
Apr 25, 2024

Conversation

rrchai
Copy link
Contributor

@rrchai rrchai commented Apr 24, 2024

The filter should now be able to search the EDAM data concepts and be used to filter challenges.

Changelogs

  • enable to list out EDAM data results (sorted alphabetically) in the input data type filter
  • enable to search data type by keywords in the search bar of the filter
  • enable to filter challenges by input data type keywords in the search bar of the page
  • enable to filter challenges by selected input data type(s)

Preview

Recording 2024-04-24 at 11 29 21


There is a bug I notice for the search dropdown filter - tracked #2648, and will be fixed in a future pr.

@rrchai rrchai requested a review from gaiaandreoletti April 24, 2024 19:47
@rrchai rrchai self-assigned this Apr 24, 2024
Copy link

Quality Gate Passed Quality Gate passed for 'openchallenges-app'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rrchai rrchai marked this pull request as ready for review April 24, 2024 19:52
Copy link
Member

@tschaffter tschaffter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new component works as described.

How does the bug that you mention and are fixing in another PR affects the shipping of the present PR?

  • Do you plan to merge the second PR into this present PR, then merge it to main?
  • Do you want to merge this PR into main first, then merge the second PR to main?
    • This is OK if you consider that the first PR could potentially be shipped to prod without the fix. We could also wait for the fix to be ready before merging the two PRs consecutively.

One concept that may help here and for sure in the future are "feature flags". Here, we could show/hide the new UI component using a boolean flag in the app config. Lets discuss this strategy next time we meet!

@rrchai
Copy link
Contributor Author

rrchai commented Apr 25, 2024

How does the bug that you mention and are fixing in another PR affects the shipping of the present PR?

  • Do you plan to merge the second PR into this present PR, then merge it to main?
  • Do you want to merge this PR into main first, then merge the second PR to main?

Since this bug has already been there on the prod site for other filters like organization, I prefer to merge this PR first once approved, and then I will fix the bug in a separated PR.

@tschaffter tschaffter merged commit f00585a into Sage-Bionetworks:main Apr 25, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Create a filter component for challenge input data types
3 participants