-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(schematic): add generate excel manifest endpoint #2569
Conversation
andrewelamb
commented
Mar 15, 2024
•
edited
Loading
edited
- fixes FDS-1605
- adds generate excel manifest endpoint
- removes input validation from generate google sheets manifest endoint (functionality moved to schematic)
- removed defaults from generate google sheets manifest endoint (to help testing)
- files for runing the API locally added to gitignore file
|
|
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewelamb I think users need to be able to download the excel file as an attachment. When I tried the endpoint you made, by using the default parameters, I saw:
This is not the expected behavior because front-end apps like DCA can't read files downloaded on the schematic side. They can't read from file path: "/workspaces/sage-monorepo/apps/schematic/api/Example.Patient.manifest.xlsx"
and get the manifest as an excel file. In summary, Schematic APIs would need to forward the excel file somehow to the front-end app when the endpoint gets called and can't just forward a path.
@andrewelamb Is this PR still relevant? |
@tschaffter Yes, I'm hoping to get back to this next week. |
@andrewelamb Could you please share an update about this PR here? |
I'm goign to close this PR. I'll start a new one since this branch is so behind main now. |