Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openchallenges): display zero search results #2553

Merged
merged 2 commits into from
Mar 8, 2024
Merged

fix(openchallenges): display zero search results #2553

merged 2 commits into from
Mar 8, 2024

Conversation

rrchai
Copy link
Contributor

@rrchai rrchai commented Mar 6, 2024 •
edited by tschaffter
Loading

Changelog

  • not display "Results (N)" when page initially load (when its value is undefined)
  • display "Results (0)" if the no search results found.

Preview

Recording 2024-03-08 at 09 28 04

Note

The changes in this pr will not reintroduce the flickering:

Recording 2024-03-08 at 09 22 58

@rrchai rrchai self-assigned this Mar 6, 2024
@rrchai rrchai added the sonar-scan-approved-deprecated Ready for Sonar code analysis label Mar 6, 2024
tschaffter
tschaffter requested changes Mar 7, 2024
View reviewed changes
Copy link
Member

@tschaffter tschaffter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Th

libs/openchallenges/challenge-search/src/lib/challenge-search.component.html Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed for 'openchallenges-app'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed for 'openchallenges-challenge-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed for 'openchallenges-organization-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed for 'openchallenges-image-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@tschaffter tschaffter self-requested a review March 8, 2024 18:03
@tschaffter
Copy link
Member

@rrchai The flickering is back for me. This happens when reaching the page directly from another website or reloading the page but not when navigating between pages. Can you reproduce this flickering.

Recording 2024-03-08 at 10 13 53

tschaffter
tschaffter requested changes Mar 8, 2024
View reviewed changes
Copy link
Member

@tschaffter tschaffter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above about the flickering

@rrchai
Copy link
Contributor Author

rrchai commented Mar 8, 2024

Interesting, the flickering is not reproduced on my end.

Recording 2024-03-08 at 13 37 30

I wonder if this flickering (from reloading the page) occurred before this PR was implemented on your end?

@tschaffter
Copy link
Member

You are right, the flickering is already present on the production site (https://openchallenges.io/challenge). So we never got rid of it...

tschaffter
tschaffter approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@tschaffter tschaffter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this PR. There is still a flickering on that page that we may never have gotten rid off. A separate ticket has been created.

@rrchai rrchai merged commit 6aff968 into Sage-Bionetworks:main Mar 8, 2024
15 checks passed
@rrchai rrchai deleted the fix-2468 branch March 8, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tschaffter tschaffter tschaffter approved these changes

@vpchung vpchung Awaiting requested review from vpchung

Assignees

@rrchai rrchai

Labels
sonar-scan-approved-deprecated Ready for Sonar code analysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Let the user know that there are no results (regression)
2 participants
@rrchai @tschaffter