feat(schematic): integration testing #2396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andrewelamb
commented
Dec 6, 2023
andrewelamb
commented
- fixes fds-1288
- fixes fds-1288
andrewelamb
requested review from
GiaJordan,
linglp,
mialy-defelice and
milen-sage
as code owners
andrewelamb
changed the title
andrewelamb
changed the title
andrewelamb
commented
Dec 6, 2023
| except ValueError as error: | ||
| # checks for specific ValueError where the url isn't correctly formatted | ||
| if str(error).startswith("unknown url type"): | ||
| raise InvalidSchemaURL("The provided URL is incorrect", schema_url) from error |
There was a problem hiding this comment.
make this message more specific
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.