-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(openchallenges): add caption showing undatedChallengeCounts in timeline plot #2353
Conversation
…me missing updates on challenge service as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comment
@rrchai The challenge service container works for me (see below). If the container keeps restarting, you could try to remove the If the issue persists, you could rebuild the dev container to start fresh (remember to run the command 🤞 HTTP/1.1 200
X-Content-Type-Options: nosniff
X-XSS-Protection: 1; mode=block
Cache-Control: no-cache, no-store, max-age=0, must-revalidate
Pragma: no-cache
Expires: 0
X-Frame-Options: DENY
Content-Type: application/json
Transfer-Encoding: chunked
Date: Tue, 14 Nov 2023 02:58:44 GMT
Connection: close
{
"years": [
"2007",
"2008",
"2009",
"2010",
"2011",
"2012",
"2013",
"2014",
"2015",
"2016",
"2017",
"2018",
"2019",
"2020",
"2021",
"2022",
"2023"
],
"challengeCounts": [
5,
8,
12,
16,
21,
27,
31,
38,
45,
54,
80,
91,
110,
129,
177,
203,
226
],
"undatedChallengeCount": 50
} |
libs/openchallenges/home/src/lib/statistics-viewer/statistics-viewer.component.ts
Outdated
Show resolved
Hide resolved
…viewer.component.ts Co-authored-by: Thomas Schaffter <[email protected]>
…-monorepo into update-timeline-plot
for future improvement: as @tschaffter suggests, the caption part can be separated from plot itself and moved to html. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I do have one small suggestion to the language used.
libs/openchallenges/home/src/lib/statistics-viewer/statistics-viewer.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good but I suggest rephrasing the caption to sound more positive (avoid double negative terms). See suggestions above.
Depends on
Grand challenges data is added inmain
Changelog
Preview
Note
The text in the preview has been updated to "*An additional 50 challenges without known start dates are not displayed."
The static value for the challenge without start date will be update with DB update as well.