Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openchallenges): add caption showing undatedChallengeCounts in timeline plot #2353

Merged
merged 14 commits into from
Nov 16, 2023

Conversation

rrchai
Copy link
Contributor

@rrchai rrchai commented Nov 13, 2023

Depends on

Changelog

  • add caption about the number of missing challenge due to lack of start date in the plot

Preview

Screen Shot 2023-11-13 at 6 31 21 PM

Note

The text in the preview has been updated to "*An additional 50 challenges without known start dates are not displayed."
The static value for the challenge without start date will be update with DB update as well.

@rrchai rrchai self-assigned this Nov 13, 2023
Copy link
Member

@tschaffter tschaffter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment

@tschaffter
Copy link
Member

tschaffter commented Nov 14, 2023

@rrchai The challenge service container works for me (see below).

If the container keeps restarting, you could try to remove the build folder of the service with ./gradlew clean, then rebuild the service BUT without relying on the Nx cache: nx build openchallenges-challenge-service --skip-nx-cache. I have the feeling that it's this cache that may have been poisoned. Running this command should properly generate the build folder and update the cache. Only then you could build the image again.

If the issue persists, you could rebuild the dev container to start fresh (remember to run the command workspace-install immediately after).

🤞

HTTP/1.1 200 
X-Content-Type-Options: nosniff
X-XSS-Protection: 1; mode=block
Cache-Control: no-cache, no-store, max-age=0, must-revalidate
Pragma: no-cache
Expires: 0
X-Frame-Options: DENY
Content-Type: application/json
Transfer-Encoding: chunked
Date: Tue, 14 Nov 2023 02:58:44 GMT
Connection: close

{
  "years": [
    "2007",
    "2008",
    "2009",
    "2010",
    "2011",
    "2012",
    "2013",
    "2014",
    "2015",
    "2016",
    "2017",
    "2018",
    "2019",
    "2020",
    "2021",
    "2022",
    "2023"
  ],
  "challengeCounts": [
    5,
    8,
    12,
    16,
    21,
    27,
    31,
    38,
    45,
    54,
    80,
    91,
    110,
    129,
    177,
    203,
    226
  ],
  "undatedChallengeCount": 50
}

@rrchai rrchai marked this pull request as ready for review November 16, 2023 16:01
@rrchai rrchai requested a review from vpchung as a code owner November 16, 2023 16:01
@rrchai rrchai changed the base branch from main to update-grand-challenge November 16, 2023 16:04
@rrchai rrchai changed the base branch from update-grand-challenge to main November 16, 2023 16:08
@rrchai rrchai requested a review from tschaffter November 16, 2023 16:09
@rrchai
Copy link
Contributor Author

rrchai commented Nov 16, 2023

for future improvement: as @tschaffter suggests, the caption part can be separated from plot itself and moved to html.

@rrchai rrchai marked this pull request as draft November 16, 2023 16:20
@rrchai rrchai marked this pull request as ready for review November 16, 2023 16:24
Copy link
Member

@vpchung vpchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I do have one small suggestion to the language used.

Copy link
Member

@tschaffter tschaffter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good but I suggest rephrasing the caption to sound more positive (avoid double negative terms). See suggestions above.

@rrchai rrchai merged commit 1068335 into Sage-Bionetworks:main Nov 16, 2023
6 checks passed
@rrchai rrchai deleted the update-timeline-plot branch November 16, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants