Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openchallenges): challenge card fixes #2315

Merged
merged 5 commits into from
Nov 3, 2023
+19 −13
Merged

fix(openchallenges): challenge card fixes #2315

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3d342b7
add new arg
vpchung Nov 2, 2023
1c59c0f
add type-hints; throw error instead of empty string return
vpchung Nov 3, 2023
918c04a
add try-catch
vpchung Nov 3, 2023
79a3a92
Update libs/openchallenges/ui/src/lib/challenge-card/challenge-card.c…
vpchung Nov 3, 2023
71bf2c6
Update libs/openchallenges/ui/src/lib/challenge-card/challenge-card.c…
vpchung Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add try-catch
@vpchung
vpchung committed Nov 3, 2023
commit 918c04af7ac7f736142e834dd66b0c7a538553d0
26 changes: 16 additions & 10 deletions libs/openchallenges/ui/src/lib/challenge-card/challenge-card.component.ts
View file
Original file line number Diff line number Diff line change
@@ -57,17 +57,23 @@ export class ChallengeCardComponent implements OnInit {
: this.imageService.getImage({
objectKey: 'banner-default.svg',
});
if (this.challenge.endDate && this.status === 'completed') {
const timeSince = this.calcTimeDiff(this.challenge.endDate, true);
if (timeSince) {
this.time_info = `Ended ${timeSince} ago`;
try {
if (this.challenge.endDate && this.status === 'completed') {
const timeSince = this.calcTimeDiff(this.challenge.endDate, true);
if (timeSince) {
this.time_info = `Ended ${timeSince} ago`;
}
} else if (this.challenge.endDate && this.status === 'active') {
this.time_info = `Ends in ${this.calcTimeDiff(
this.challenge.endDate
)}`;
} else if (this.challenge.startDate && this.status === 'upcoming') {
this.time_info = `Starts in ${this.calcTimeDiff(
this.challenge.startDate
)}`;
}
} else if (this.challenge.endDate && this.status === 'active') {
this.time_info = `Ends in ${this.calcTimeDiff(this.challenge.endDate)}`;
} else if (this.challenge.startDate && this.status === 'upcoming') {
this.time_info = `Starts in ${this.calcTimeDiff(
this.challenge.startDate
)}`;
} catch (e: unknown) {
console.log(e);
}
}
}