Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(openchallenges): add Team button to OC navbar #2306

Merged
merged 4 commits into from
Nov 1, 2023
Merged

feat(openchallenges): add Team button to OC navbar #2306

merged 4 commits into from
Nov 1, 2023

Conversation

tschaffter
Copy link
Member

@tschaffter tschaffter commented Nov 1, 2023 •
edited
Loading

Closes #2303

Changelog

  • Add the button "Team" to the right panel of the navbar
  • Replace href by routerLink in the navbar and footer for links that target app pages

Note
Navigating to a page of the app with href destroys and reloads the app. This can be observed by looking at the navbar that flickers when navigating with href. Instead, navigating to pages of the app should be done with routerLink (requires to import the RouterModule). In that case, the navbar will remain and only the components that are no longer used will be destroyed, which leads to faster navigation.

Preview

Option 1

image

Option 2

image

@tschaffter tschaffter self-assigned this Nov 1, 2023
@tschaffter tschaffter marked this pull request as ready for review November 1, 2023 21:12
vpchung
vpchung approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@vpchung vpchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Between the two options, I like 2 for consistency.

LGTM

rrchai
rrchai approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@rrchai rrchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tschaffter tschaffter merged commit c16aee2 into Sage-Bionetworks:main Nov 1, 2023
6 checks passed
@tschaffter tschaffter deleted the team-button branch November 1, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrchai rrchai rrchai approved these changes

@vpchung vpchung vpchung approved these changes

Assignees

@tschaffter tschaffter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Add Team button to OC navbar ⭐
3 participants
@tschaffter @vpchung @rrchai