fix(openchallenges): expore Location.replaceState() to fix scrolling issue
#2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschaffter
changed the title
Location.replaceState() to fix scrolling issueLocation.replaceState() to fix scrolling issue
|
@rrchai I was wondering whether there was a simpler solution to the scrolling issue. I may have found one (see above). It seems that the existing code relies on on page navigation to trigger new searches. A more performant approach aligned with this PR would be to trigger queries when the object |
|
@tschaffter Thanks for the initial exploration of |
|
See comment from Rong above. Closing this exploratory PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2154
Description
Explore an alternative solution to #2189 that may be simpler.
Source
References