-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use the org acronym when generating the org avatar #1523
feat: Use the org acronym when generating the org avatar #1523
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea to limit the # of characters displayed in the orgs avatars. I think limit == 2 is a bit too low and would suggest using limit == 3 or limit==4 to avoid end user confusion when viewing the site and prevent overlap in displayed acronyms. A suggestion to avoid this would be to implement a tooltip that will display the full acronym when the user hovers over the avatar.
Looking over our collected data, upping the max limit to 3 or 4 might not be enough either -- we have some acronyms that are 8 characters long, e.g. Ergo, I'm arguing for displaying only the first character. P.S. I like the tooltip idea! |
@vpchung @mdsage1 Here are some notes from our stand-up meeting:
What is your preferred text length based on the above notes between 1, 2, and 4-letter strings in the avatar? |
@vpchung @mdsage1 Thanks for the feedback. I prefer the 1-letter initials to the 4-letter. The benefit is that users shouldn't try to make sense out of a 4-letter initials that correspond to a cropped acronym. A 4-letter acronym may also be difficult to read in a smaller version of the avatars, e.g. when displayed in a list (though we could cross that bridge when we are there). |
Co-authored-by: Verena Chung <[email protected]>
* Rebase from main * Rebase from main * add acronyms; update challenge contributors * feat: Use the org acronym when generating the org avatar (#1523) * Update API client for Angular * Fix mock organizations in app * Convert the avatar component to standalone * Enable to specify acronym to the avatar * Restore src * Add comment * Fix test * Update libs/openchallenges/ui/src/lib/avatar/avatar.component.ts Co-authored-by: Verena Chung <[email protected]> * Restore images --------- Co-authored-by: Verena Chung <[email protected]> * Get image URL only when key is not null or empty --------- Co-authored-by: verena <[email protected]>
Changelog
organization.acronym
.Notes
avatar.name
will result in a single-letter initial (1-word acronym => 1-letter initial). A solution is to setavatar.value
to the acronym. However, theavatar.name
should not be specified because it takes priority overavatar.value
.Preview
organization.acronym
can be specified instead of generating initials fromorganization.name
(though this should not affect the generation of 1-letter initials).Below is what the user would see if these orgs didn't have a logo: