Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-1263] Fix bed file duplicates #562

Merged
merged 6 commits into from
May 13, 2024
Merged

Conversation

rxu17
Copy link
Contributor

@rxu17 rxu17 commented May 1, 2024

Purpose: This is a draft PR. This PR fixes the bug that always appends each bed file to the bed synapse database table during processing creating duplicates in the bed database table.

Changes:

Tests:

Depends on #565

Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM! Thanks for adding tests and for the fix!

Although, not sure why the docker build is failing...

@rxu17 rxu17 marked this pull request as ready for review May 1, 2024 15:35
@rxu17 rxu17 requested a review from a team as a code owner May 1, 2024 15:35
@rxu17
Copy link
Contributor Author

rxu17 commented May 1, 2024

Although, not sure why the docker build is failing...

Yeah, seems to do with compilation issues during the installation of rlang and them enforcing warnings as errors (funny, no issue a couple days ago)

Copy link

Quality Gate Passed Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rxu17
Copy link
Contributor Author

rxu17 commented May 13, 2024

@thomasyu888 Should this be directly merged to main because we have our upcoming release? I forgot our decision on this.

@thomasyu888
Copy link
Member

@rxu17 hmmm... it might be best to push to develop and wait for all the changes for this release. One reason is because the docker build fix is in develop, so pushing directly to main may break the docker build.

Thoughts?

We should probably create a ticket to manually drop dups from the bed table when we are ready to push everything up. There's a bit of risk of releasing before the public release, so we can discuss whether we should or not.

@rxu17
Copy link
Contributor Author

rxu17 commented May 13, 2024

Thanks for the reminder about the docker build (I realize we didn't push that directly to main as well which makes sense as well). Will just merge to develop for now

@rxu17 rxu17 merged commit ae4465a into develop May 13, 2024
14 checks passed
@rxu17 rxu17 deleted the gen-1263-fix-bed-file-dups branch May 13, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants