-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEN-1263] Fix bed file duplicates #562
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 LGTM! Thanks for adding tests and for the fix!
Although, not sure why the docker build is failing...
Yeah, seems to do with compilation issues during the installation of |
|
@thomasyu888 Should this be directly merged to |
@rxu17 hmmm... it might be best to push to develop and wait for all the changes for this release. One reason is because the docker build fix is in develop, so pushing directly to main may break the docker build. Thoughts? We should probably create a ticket to manually drop dups from the bed table when we are ready to push everything up. There's a bit of risk of releasing before the public release, so we can discuss whether we should or not. |
Thanks for the reminder about the docker build (I realize we didn't push that directly to main as well which makes sense as well). Will just merge to |
Purpose: This is a draft PR. This PR fixes the bug that always appends each bed file to the bed synapse database table during processing creating duplicates in the bed database table.
Changes:
process_steps
Tests:
update_table
function as well since there wasn't any presentDepends on #565