[GEN-868] add year death validation #560
Conversation
Will do |
danlu1
force-pushed
the
gen-868-add-year-death-validation
branch
from
9e41546 to
41b0356
Compare
| if haveColumn: | ||
| error = _check_year_death_validity(clinicaldf=clinicaldf) | ||
| total_error.write(error) | ||
|
|
There was a problem hiding this comment.
A stretch goal outside of the explicit scope of this change would be to split out these other items into their own functions. Is there a tech debt jira that already exists, or could one be created to address this item?
Cc: @rxu17
There was a problem hiding this comment.
Yes we have a tech debt jira/part of the overarching goal for this. The goal is to eventually have a validation function for each validation rule for each fileformat especially when we want to implement GX framework for this.
I think this is part of our documentation epic as well. To break up the validation code so we can document each validation rule individually and completely.
This is not just happening here but throughout the genie code (also for processing as well) but we definitely want to start with validation first.
|
Problem:
Lack of validation check on whether YEAR_DEATH >= YEAR_CONTACT
Solution:
Add the validation check to compare YEAR_DEATH and YEAR_CONTACT when both of them exist and not NAs.
Testing:
Unit test has been added.