[GEN-1164] add workflow to build docker image and push it to ghcr #556
Conversation
Remove tags section in docker/metadata-action since only push event will generate tag for branch. But we want branch based cache.
Disable provenance to avoid caching manifest
rxu17
changed the title
.github/workflows/ci.yml
Outdated
| @@ -5,15 +5,18 @@ name: build | |||
|
|
|||
| on: | |||
| push: | |||
| branches: | |||
| - develop | |||
| branches: [develop, 'GEN*', 'gen*'] | |||
There was a problem hiding this comment.
Just a comment to note that test and lint will run for every push now to the feature branches regardless of whether there is a PR or not. Nothing to fix here.
There was a problem hiding this comment.
Yes, right now, push to develop, branches with gen/GEN prefix, all PRs and release will trigger the test and lint job.
.github/workflows/ci.yml
Outdated
| @@ -5,15 +5,18 @@ name: build | |||
|
|
|||
| on: | |||
| push: | |||
| branches: | |||
| - develop | |||
| branches: [develop, 'GEN*', 'gen*'] | |||
There was a problem hiding this comment.
Actually could you also add main to the branches here? I don't know if your current setup for ghcr will always create a docker image that is based on the latest version of the repo like we have for dockerhub? Will this setup create a latest tag by default?
Add main branch to push event branches.
|
Problem:
There are limited admin seats that we can have on dockerHub.
Solution:
Switch to pushing our docker images to ghcr
Output:
The docker image and cached image can be viewed here.