Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-973] Fix bed file-clinical file cross-validation #540

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

rxu17
Copy link
Contributor

@rxu17 rxu17 commented Nov 16, 2023

Purpose: This is to add a fix to the cross validation for bed files against SEQ_ASSAY_IDs in clinical files

Changes: Changes were added to _cross_validate_bed_files_exist to do the following:

Testing:

  • Tests were modified to have different case/underscored SEQ_ASSAY_ID values in the clinical file

@rxu17 rxu17 requested a review from a team as a code owner November 16, 2023 01:33
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Thanks for fixing this! Nice find!

@rxu17 rxu17 merged commit 6ceb82b into develop Nov 16, 2023
7 checks passed
@rxu17 rxu17 deleted the gen-973-fix-bed-clinical-validation branch November 16, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants