AG-1472: ensure e2e tests are run when image has already been built

Sage-Bionetworks · beatrizsaldana · Dec 18, 2024 · Jun 5, 2024 · Jun 5, 2024 · Jun 5, 2024
commit 48b4d5a33892756af126c13e8838486cf9c9a87d
diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml
@@ -161,7 +161,9 @@ jobs:
     needs:
       - check-for-image
       - build-image
-    if: ${{ needs.check-for-image.result == 'success' && (needs.build-image.result == 'success' || needs.build-image.result == 'skipped')}}
+    # always() prevents skipping this job when build-image was skipped
+    # see https://github.com/actions/runner/issues/491
+    if: ${{ always() && needs.check-for-image.result == 'success' && (needs.build-image.result == 'success' || needs.build-image.result == 'skipped')}}
     timeout-minutes: 60
     runs-on: ubuntu-20.04
     permissions:

diff --git a/...app/features/genes/components/gene-comparison-tool/gene-comparison-tool.component.spec.ts b/...app/features/genes/components/gene-comparison-tool/gene-comparison-tool.component.spec.ts
      ) as HTMLElement;
      filterClearButton.click();

      fixture.whenStable().then(() => {
        fixture.detectChanges();
        expectSignificanceThresholdIsNotApplied();
      });
      ) as HTMLElement;
      clearAllButton.click();

      fixture.whenStable().then(() => {
        fixture.detectChanges();
        expectSignificanceThresholdIsNotApplied();
      });
      component.initData([comparisonGeneMock1, comparisonGeneMock2]);
      route.queryParams = of({});

      fixture.whenStable().then(() => {
        fixture.detectChanges();
        expectSignificanceThresholdIsNotApplied();

        const toggle = element.querySelector(TOGGLE_CLASS) as HTMLElement;
        toggle.click();

        fixture.whenStable().then(() => {
          fixture.detectChanges();
          expectSignificanceThresholdIsApplied();
        });
diff --git a/src/app/features/genes/components/gene-comparison-tool/gene-comparison-tool.component.ts b/src/app/features/genes/components/gene-comparison-tool/gene-comparison-tool.component.ts
  }

  copyUrl() {
    navigator.clipboard.writeText(window.location.href);
    const self = this;
    this.messageService.clear();
    this.messageService.add({
diff --git a/src/app/features/genes/components/gene-table/gene-table.component.ts b/src/app/features/genes/components/gene-table/gene-table.component.ts

    if (el[0]) {
      if (!screenfull.isFullscreen) {
        screenfull.request(el[0]);
      } else {
        screenfull.exit();
      }
    }
  }
diff --git a/src/server/api.ts b/src/server/api.ts
  database.url = 'mongodb://localhost:27017/agora';
 }

 mongoose.connect(database.url);

 // Get the default connection
 const connection = mongoose.connection;
	) as HTMLElement;
	filterClearButton.click();

	fixture.whenStable().then(() => {
Check warning on line 434 in src/app/features/genes/components/gene-comparison-tool/gene-comparison-tool.component.spec.ts GitHub Actions / build (16.x) Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
	fixture.detectChanges();
	expectSignificanceThresholdIsNotApplied();
	});
	) as HTMLElement;
	clearAllButton.click();

	fixture.whenStable().then(() => {
Check warning on line 452 in src/app/features/genes/components/gene-comparison-tool/gene-comparison-tool.component.spec.ts GitHub Actions / build (16.x) Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
	fixture.detectChanges();
	expectSignificanceThresholdIsNotApplied();
	});
	component.initData([comparisonGeneMock1, comparisonGeneMock2]);
	route.queryParams = of({});

	fixture.whenStable().then(() => {
Check warning on line 463 in src/app/features/genes/components/gene-comparison-tool/gene-comparison-tool.component.spec.ts GitHub Actions / build (16.x) Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
	fixture.detectChanges();
	expectSignificanceThresholdIsNotApplied();

	const toggle = element.querySelector(TOGGLE_CLASS) as HTMLElement;
	toggle.click();

	fixture.whenStable().then(() => {
Check warning on line 470 in src/app/features/genes/components/gene-comparison-tool/gene-comparison-tool.component.spec.ts GitHub Actions / build (16.x) Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
	fixture.detectChanges();
	expectSignificanceThresholdIsApplied();
	});
	}

	copyUrl() {
	navigator.clipboard.writeText(window.location.href);
Check warning on line 997 in src/app/features/genes/components/gene-comparison-tool/gene-comparison-tool.component.ts GitHub Actions / build (16.x) Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
	const self = this;
	this.messageService.clear();
	this.messageService.add({

	if (el[0]) {
	if (!screenfull.isFullscreen) {
	screenfull.request(el[0]);
Check warning on line 170 in src/app/features/genes/components/gene-table/gene-table.component.ts GitHub Actions / build (16.x) Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
	} else {
	screenfull.exit();
Check warning on line 172 in src/app/features/genes/components/gene-table/gene-table.component.ts GitHub Actions / build (16.x) Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
	}
	}
	}
	database.url = 'mongodb://localhost:27017/agora';
	}

	mongoose.connect(database.url);
Check warning on line 83 in src/server/api.ts GitHub Actions / build (16.x) Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator

	// Get the default connection
	const connection = mongoose.connection;