-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for QPTIFF #55
Add support for QPTIFF #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, have you run any .qptiff
files through the TiffSuite
? I'm assuming they would pass all of the normal .tif
tests (except for file extension until after this is merged), but it might be good to make sure.
Co-authored-by: Brad Macdonald <[email protected]>
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm guessing the one acceptance test is failing because this contribution is coming from a fork which doesn't have a Synapse Auth token with the necessary permissions. The test suite passes locally for me and the change is tiny so I think we are safe to merge this. I will be sure tests all pass before releasing a patch with this change.
Thanks for the contribution @adamjtaylor!
Edit: Also for clarity, I ran a test run of DCQC with a QPTIFF file and it worked as expected.
QPTIFF is a TIFF-based image format used by PerkinsElmer Vecra mIF and Akoya Phenocycler CODEX instruments. This PR adds basic support for them by including files with the
.qptiff
extension in the TIFF file type.